Skip to content

gh-63161: Add more tests for source encoding #139440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

gh-63161: Add more tests for source encoding #139440

merged 1 commit into from
Sep 30, 2025

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 30, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Sep 30, 2025
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 30, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 30, 2025
Closed
@vstinner
Copy link
Member

vstinner commented Sep 30, 2025 •
edited
Loading

Two tests are failing:

======================================================================
FAIL: test_nul_in_first_coding_line (test.test_source_encoding.FileSourceEncodingTest.test_nul_in_first_coding_line)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_source_encoding.py", line 316, in test_nul_in_first_coding_line
    self.check_script_error(src, br"source code (string )?cannot contain null bytes")
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_source_encoding.py", line 425, in check_script_error
    self.assertRegex(res.err.rstrip().splitlines()[-1], b'SyntaxError: ' + expected)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Regex didn't match: b'SyntaxError: source code (string )?cannot contain null bytes' not found in b'\x1b[1;35mSyntaxError\x1b[0m: \x1b[35msource code cannot contain null bytes\x1b[0m'

======================================================================
FAIL: test_nul_in_second_coding_line (test.test_source_encoding.FileSourceEncodingTest.test_nul_in_second_coding_line)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_source_encoding.py", line 323, in test_nul_in_second_coding_line
    self.check_script_error(src, br"source code (string )?cannot contain null bytes")
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_source_encoding.py", line 425, in check_script_error
    self.assertRegex(res.err.rstrip().splitlines()[-1], b'SyntaxError: ' + expected)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Regex didn't match: b'SyntaxError: source code (string )?cannot contain null bytes' not found in b'\x1b[1;35mSyntaxError\x1b[0m: \x1b[35msource code cannot contain null bytes\x1b[0m'

@serhiy-storchaka serhiy-storchaka merged commit b2f5ad0 into python:main Sep 30, 2025
43 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 30, 2025

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_source_encoding2 branch September 30, 2025 09:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2025
@serhiy-storchaka @miss-islington
pythongh-63161: Add more tests for source encoding (pythonGH-139440)
91c8f4d 
(cherry picked from commit b2f5ad0)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2025
@serhiy-storchaka @miss-islington
pythongh-63161: Add more tests for source encoding (pythonGH-139440)
2e73fb6 
(cherry picked from commit b2f5ad0)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 30, 2025

GH-139442 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 30, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 30, 2025

GH-139443 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 30, 2025
Yhg1s pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-63161: Add more tests for source encoding (GH-139440) (#139443
4216ea7 
)

(cherry picked from commit b2f5ad0)

Co-authored-by: Serhiy Storchaka <[email protected]>
encukou pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-63161: Add more tests for source encoding (GH-139440) (GH-1…
a869796 
…39442)

(cherry picked from commit b2f5ad0)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @vstinner