gh-80145: Exclude '.' directory when adding directories to a tar archive

Lib/tarfile.py

@@ -2208,7 +2208,8 @@ def add(self, name, arcname=None, recursive=True, *, filter=None):
                 self.addfile(tarinfo, f)
 
         elif tarinfo.isdir():
-            self.addfile(tarinfo)
+            if tarinfo.name != os.curdir:
+                self.addfile(tarinfo)
             if recursive:
                 for f in sorted(os.listdir(name)):
                     self.add(os.path.join(name, f), os.path.join(arcname, f),

Lib/test/test_shutil.py

@@ -1637,7 +1637,7 @@ def test_make_tarball(self):
         self.assertTrue(tarfile.is_tarfile(tarball))
         with tarfile.open(tarball, 'r:gz') as tf:
             self.assertCountEqual(tf.getnames(),
-                                  ['.', './sub', './sub2',
+                                  ['./sub', './sub2',
                                    './file1', './file2', './sub/file3'])
 
         # trying an uncompressed one
@@ -1648,7 +1648,7 @@ def test_make_tarball(self):
         self.assertTrue(tarfile.is_tarfile(tarball))
         with tarfile.open(tarball, 'r') as tf:
             self.assertCountEqual(tf.getnames(),
-                                  ['.', './sub', './sub2',
+                                  ['./sub', './sub2',
                                   './file1', './file2', './sub/file3'])
 
     def _tarinfo(self, path):

Lib/test/test_tarfile.py

@@ -1587,8 +1587,9 @@ def test_cwd(self):
             tar = tarfile.open(tmpname, "r")
             try:
                 for t in tar:
-                    if t.name != ".":
-                        self.assertTrue(t.name.startswith("./"), t.name)
+                    # gh-80145: "." is now excluded from tarfiles
+                    self.assertNotEqual(t.name, os.curdir)
+                    self.assertTrue(t.name.startswith("./"), t.name)
             finally:
                 tar.close()
 

Misc/NEWS.d/next/Library/2019-06-02-02-42-43.bpo-35964.wG23fC.rst

@@ -0,0 +1,2 @@
+The tarfile module now excludes '.' directory entries when adding
+a directory to a tar archive.  Patch by Jeffrey Kintscher.