Skip to content

WIP: bpo-36345: Remove the deprecated Tools/scripts/serve.py script #12522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: bpo-36345: Remove the deprecated Tools/scripts/serve.py script #12522

wants to merge 1 commit into from

Conversation

@matrixise
Copy link
Member

@matrixise matrixise commented Mar 24, 2019 •
edited by bedevere-bot
Loading

This PR should be merged after the PR #12408. Once that one will merged I will remove the WIP status for a review.

https://bugs.python.org/issue36345

@matrixise matrixise changed the title bpo-36345: Remove the deprecated Tools/scripts/serve.py script WIP: bpo-36345: Remove the deprecated Tools/scripts/serve.py script Mar 24, 2019
ned-deily
ned-deily requested changes Mar 24, 2019
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on the bug tracker issue, I don't think we should delete this since it and other files in the Tools directory are or optionally are installed on users' systems as part of some distribution packages and it still serves its purpose as a demo.

@bedevere-bot
Copy link

bedevere-bot commented Mar 24, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise
Copy link
Member Author

matrixise commented Mar 25, 2019

I close this PR, we will avoid to merge it. Thanks @ned-deily

@matrixise matrixise closed this Mar 25, 2019
@matrixise matrixise mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matrixise @bedevere-bot @ned-deily @the-knights-who-say-ni