Skip to content

Conversation

@webknjaz
Copy link
Contributor

.
(cherry picked from commit a3f7db9)

if: needs.check_source.outputs.run_tests == 'true'
strategy:
matrix:
free-threading:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no free-threading in 3.12.

The Windows 3.12 backport included free-threading things in reusable-windows.yml but build.yml didn't mention it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... because the #121776 backport hasn't been merged yet :)

But that comments out the free-threading: true job. Do the same here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that comments out the free-threading: true job. Do the same here?

Yes! I forgot about that one, only fixed the merge conflicts. I left it commented out to facilitate any future backports, reducing possible conflicts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why that doesn't fail the CI and saw this:

configure: WARNING: unrecognized options: --disable-gil

@hugovk any reason invalid flags don't crash the build process?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out that matrix factor. Marking this thread as resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why that doesn't fail the CI and saw this:

configure: WARNING: unrecognized options: --disable-gil

@hugovk any reason invalid flags don't crash the build process?

Let's ask @erlend-aasland

Co-authored-by: Hugo van Kemenade <[email protected]>.
(cherry picked from commit a3f7db9)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@webknjaz webknjaz force-pushed the backport-a3f7db9-3.12 branch from e1254a8 to 1d08251 Compare July 22, 2024 13:41
@hugovk hugovk merged commit 8d1f157 into python:3.12 Jul 22, 2024
@hugovk
Copy link
Member

hugovk commented Jul 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants