gh-120522: Revert "Add a --with-app-store-compliance configure option to patch out problematic code" (gh-120984)
#121844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e option to patch out problematic code (python#120984)" This reverts commit 48cd104 prior to the release of 3.13.0b4 to allow for additional review time.
ned-deily
requested review from
a team,
corona10,
erlend-aasland and
freakboy3742
as code owners
freakboy3742
approved these changes
Jul 16, 2024
Contributor
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
One note about a part of the patch that probably shouldn't be reverted (but is easy to fix again later), but otherwise LGTM.
| The module has been designed to match the internet RFC on Relative Uniform | ||
| Resource Locators. It supports the following URL schemes: ``file``, ``ftp``, | ||
| ``gopher``, ``hdl``, ``http``, ``https``, ``imap``, ``itms-services``, ``mailto``, ``mms``, | ||
| ``gopher``, ``hdl``, ``http``, ``https``, ``imap``, ``mailto``, ``mms``, |
Contributor
There was a problem hiding this comment.
It's worth noting that while this is what would be a strict reverse of the original PR, this change was actually correct - the list didn't previously list itms-services at all, despite being supported.
|
Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2024
…e option to patch out problematic code" (pythongh-120984) (pythonGH-121844) This reverts commit 48cd104 prior to the release of 3.13.0b4 to allow for additional review time. (cherry picked from commit f27593a) Co-authored-by: Ned Deily <[email protected]>
|
GH-121845 is a backport of this pull request to the 3.13 branch. |
ned-deily
added a commit
that referenced
this pull request
Jul 16, 2024
…re option to patch out problematic code" (GH-121844) (#121845) This reverts commit 0dfb437 prior to the release of 3.13.0b4 to allow for additional review time. (cherry picked from commit f27593a) Co-authored-by: Ned Deily <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…e option to patch out problematic code" (pythongh-120984) (python#121844) This reverts commit 48cd104 prior to the release of 3.13.0b4 to allow for additional review time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 48cd104 prior to the release of 3.13.0b4 to allow for additional review time.
📚 Documentation preview 📚: https://cpython-previews--121844.org.readthedocs.build/