Skip to content

gh-116439: Ensure thread is joined in test_empty_authkey #116442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-116439: Ensure thread is joined in test_empty_authkey #116442

wants to merge 1 commit into from

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 6, 2024 •
edited by bedevere-app bot
Loading

The "dangling" thread can lead to "ENV CHANGED" test failures.

@colesbury colesbury added tests Tests in the Lib/test dir skip news labels Mar 6, 2024
@colesbury colesbury requested a review from gpshead as a code owner March 6, 2024 21:39
@bedevere-app bedevere-app bot mentioned this pull request Mar 6, 2024
Closed
@colesbury
Copy link
Contributor Author

colesbury commented Mar 6, 2024

Oops, already fixed in #116434... what timing

@colesbury colesbury closed this Mar 6, 2024
@colesbury colesbury deleted the gh-116439-authkey branch March 6, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@colesbury