gh-116326: Handler errors correctly in getwindowsversion in sysmodule
#116339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
skip news
needs backport to 3.11
Member
Author
|
Thanks! I would like to wait for a bit for @ericsnowcurrently's review as a code owner :) |
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
PyErr_Clear() calls in this function looks suspicious too. In good code it should only be called for expected exceptions, the others should be reported as errors.
Member
Author
I think that this is a side-effect of using |
Member
|
Yes, one of |
sobolevn
changed the title
getwindowsversion in `sysmodulegetwindowsversion in sysmodule
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2024
…sysmodule` (pythonGH-116339) (cherry picked from commit c91bdf8) Co-authored-by: Nikita Sobolev <[email protected]>
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
GH-116354 is a backport of this pull request to the 3.12 branch. |
Member
Author
|
@serhiy-storchaka what is the best way to do backports here? I forgot that |
Member
|
Explicitly check for AttributeError. |
|
Member
Author
|
This failure also happened on a previous PR: https://buildbot.python.org/all/#/builders/1102/builds/751/steps/5/logs/stdio Plus, it is a debian failure for a windows-only change. |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Mar 5, 2024
…n` in `sysmodule` (pythonGH-116339) (cherry picked from commit c91bdf8) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-116388 is a backport of this pull request to the 3.11 branch. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyErr_Occurredis no longer needed, because we check for allNULLvaluesPy_BuildValue("(kkk)", ...)can failsys_getwindowsversion_implmight potentially swallow errors insysmodule.c#116326