Use SystemError

Author: vstinner

Lib/test/test_capi/test_list.py

@@ -311,8 +311,8 @@ def test_list_clear(self):
         self.assertEqual(list_clear(lst), 0)
         self.assertEqual(lst, [])
 
-        self.assertRaises(TypeError, list_clear, ())
-        self.assertRaises(TypeError, list_clear, object())
+        self.assertRaises(SystemError, list_clear, ())
+        self.assertRaises(SystemError, list_clear, object())
 
         # Item finalizer modify the list
         lst = []
@@ -338,6 +338,7 @@ def test_list_extend(self):
         self.assertEqual(lst, list("abcabc"))
 
         self.assertRaises(TypeError, list_extend, [], object())
+        self.assertRaises(SystemError, list_extend, (), list("abc"))
 
         # CRASHES list_extend(NULL, [])
         # CRASHES list_extend([], NULL)

Objects/listobject.c

@@ -1024,8 +1024,7 @@ int
 PyList_Extend(PyObject *self, PyObject *iterable)
 {
     if (!PyList_Check(self)) {
-        PyErr_Format(PyExc_TypeError, "expected list, got %s",
-                     Py_TYPE(self)->tp_name);
+        PyErr_BadInternalCall();
         return -1;
     }
     return list_extend((PyListObject*)self, iterable);
@@ -1036,8 +1035,7 @@ int
 PyList_Clear(PyObject *self)
 {
     if (!PyList_Check(self)) {
-        PyErr_Format(PyExc_TypeError, "expected list, got %s",
-                     Py_TYPE(self)->tp_name);
+        PyErr_BadInternalCall();
         return -1;
     }
     list_clear((PyListObject*)self);