Address review

Author: sobolevn

Lib/test/test_ast/test_ast.py

@@ -94,11 +94,11 @@ def cleanup():
 
         del ast.AST._fields
 
-        msg = 'AST has no fields'
+        msg = "type object 'ast.AST' has no attribute '_fields'"
         # Both examples used to crash:
-        with self.assertRaisesRegex(TypeError, msg):
+        with self.assertRaisesRegex(AttributeError, msg):
             ast.AST(arg1=123)
-        with self.assertRaisesRegex(TypeError, msg):
+        with self.assertRaisesRegex(AttributeError, msg):
             ast.AST()
 
     def test_AST_garbage_collection(self):

Misc/NEWS.d/next/Library/2024-10-29-11-45-44.gh-issue-126105.cOL-R6.rst

@@ -1 +1 @@
-Fix a crash in :mod:`ast` when ``_fields`` attribute is deleted.
+Fix a crash in :mod:`ast` when the :attr:`ast.AST._fields` attribute is deleted.

Parser/asdl_c.py

@@ -884,13 +884,9 @@ def visitModule(self, mod):
     Py_ssize_t i, numfields = 0;
     int res = -1;
     PyObject *key, *value, *fields, *attributes = NULL, *remaining_fields = NULL;
-    if (PyObject_GetOptionalAttr((PyObject*)Py_TYPE(self), state->_fields, &fields) < 0) {
-        goto cleanup;
-    }
+
+    fields = PyObject_GetAttr((PyObject*)Py_TYPE(self), state->_fields);
     if (fields == NULL) {
-        PyErr_Format(PyExc_TypeError,
-                     "%.400s has no fields",
-                     _PyType_Name(Py_TYPE(self)));
         goto cleanup;
     }