[3.5] bpo-30567: Fix refleak in sys.getwindowsversion (GH-1940) (#1971)

serhiy-storchaka · web-flow · commit 86f8f1f05cd5 · 2017-06-06T19:23:21.000+03:00
(cherry picked from commit 48fb766)
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -897,10 +897,10 @@ sys_getwindowsversion(PyObject *self)
         }
         PyMem_RawFree(verblock);
     }
-    PyStructSequence_SET_ITEM(version, pos++, PyTuple_Pack(3,
-        PyLong_FromLong(realMajor),
-        PyLong_FromLong(realMinor),
-        PyLong_FromLong(realBuild)
+    PyStructSequence_SET_ITEM(version, pos++, Py_BuildValue("(kkk)",
+        realMajor,
+        realMinor,
+        realBuild
     ));
 
     if (PyErr_Occurred()) {

Original file line number	Diff line number	Diff line change
`@@ -897,10 +897,10 @@ sys_getwindowsversion(PyObject *self)`
`897`	`897`	`}`
`898`	`898`	`PyMem_RawFree(verblock);`
`899`	`899`	`}`
`900`		`- PyStructSequence_SET_ITEM(version, pos++, PyTuple_Pack(3,`
`901`		`- PyLong_FromLong(realMajor),`
`902`		`- PyLong_FromLong(realMinor),`
`903`		`- PyLong_FromLong(realBuild)`
	`900`	`+ PyStructSequence_SET_ITEM(version, pos++, Py_BuildValue("(kkk)",`
	`901`	`+ realMajor,`
	`902`	`+ realMinor,`
	`903`	`+ realBuild`
`904`	`904`	`));`
`905`	`905`
`906`	`906`	`if (PyErr_Occurred()) {`