[3.6] bpo-30567: Fix refleak in sys.getwindowsversion (GH-1940) (#1970)

serhiy-storchaka · web-flow · commit 68e5af89d46d · 2017-06-06T19:23:02.000+03:00
(cherry picked from commit 48fb766)
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -985,10 +985,10 @@ sys_getwindowsversion(PyObject *self)
         }
         PyMem_RawFree(verblock);
     }
-    PyStructSequence_SET_ITEM(version, pos++, PyTuple_Pack(3,
-        PyLong_FromLong(realMajor),
-        PyLong_FromLong(realMinor),
-        PyLong_FromLong(realBuild)
+    PyStructSequence_SET_ITEM(version, pos++, Py_BuildValue("(kkk)",
+        realMajor,
+        realMinor,
+        realBuild
     ));
 
     if (PyErr_Occurred()) {

Original file line number	Diff line number	Diff line change
`@@ -985,10 +985,10 @@ sys_getwindowsversion(PyObject *self)`
`985`	`985`	`}`
`986`	`986`	`PyMem_RawFree(verblock);`
`987`	`987`	`}`
`988`		`- PyStructSequence_SET_ITEM(version, pos++, PyTuple_Pack(3,`
`989`		`- PyLong_FromLong(realMajor),`
`990`		`- PyLong_FromLong(realMinor),`
`991`		`- PyLong_FromLong(realBuild)`
	`988`	`+ PyStructSequence_SET_ITEM(version, pos++, Py_BuildValue("(kkk)",`
	`989`	`+ realMajor,`
	`990`	`+ realMinor,`
	`991`	`+ realBuild`
`992`	`992`	`));`
`993`	`993`
`994`	`994`	`if (PyErr_Occurred()) {`