Skip to content

Commit 5274cc3

Browse files
committed
Revert the change to use Argument Clinic
1 parent 956d773 commit 5274cc3

File tree

2 files changed

+8
-105
lines changed

2 files changed

+8
-105
lines changed

Modules/clinic/mmapmodule.c.h

Lines changed: 0 additions & 70 deletions
This file was deleted.

Modules/mmapmodule.c

Lines changed: 8 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@
2828
#include "pycore_fileutils.h" // _Py_stat_struct
2929
#include "pycore_weakref.h" // FT_CLEAR_WEAKREFS()
3030

31-
/*[clinic input]
32-
module mmap
33-
class mmap.mmap "mmap_object *" "mmap_object_type"
34-
[clinic start generated code]*/
35-
/*[clinic end generated code: output=da39a3ee5e6b4b0d input=4ebde54549b9daa7]*/
36-
3731
#include <stddef.h> // offsetof()
3832
#ifndef MS_WINDOWS
3933
# include <unistd.h> // close()
@@ -135,15 +129,6 @@ typedef struct {
135129

136130
#define mmap_object_CAST(op) ((mmap_object *)(op))
137131

138-
#include "clinic/mmapmodule.c.h"
139-
140-
static int
141-
mmap_object_traverse(PyObject *op, visitproc visit, void *arg)
142-
{
143-
Py_VISIT(Py_TYPE(op));
144-
return 0;
145-
}
146-
147132
static void
148133
mmap_object_dealloc(PyObject *op)
149134
{
@@ -942,31 +927,19 @@ mmap_tell_method(PyObject *op, PyObject *Py_UNUSED(ignored))
942927
return PyLong_FromSize_t(self->pos);
943928
}
944929

945-
/*[clinic input]
946-
mmap.mmap.flush
947-
948-
offset: Py_ssize_t = 0
949-
size: Py_ssize_t(c_default="-1") = None
950-
/
951-
952-
Flushes changes made to the in-memory copy of a file back to disk.
953-
954-
If offset and size are specified, only the specified range will
955-
be flushed. If not specified, the entire mapped region will be
956-
flushed.
957-
[clinic start generated code]*/
958-
959930
static PyObject *
960-
mmap_mmap_flush_impl(mmap_object *self, Py_ssize_t offset, Py_ssize_t size)
961-
/*[clinic end generated code: output=956ced67466149cf input=07c2c6d4e69263a4]*/
931+
mmap_flush_method(PyObject *op, PyObject *args)
962932
{
933+
Py_ssize_t offset = 0;
934+
Py_ssize_t size = -1;
935+
mmap_object *self = mmap_object_CAST(op);
963936
CHECK_VALID(NULL);
964-
965-
// If size is -1 (default), calculate size from offset to end.
937+
if (!PyArg_ParseTuple(args, "|nn:flush", &offset, &size)) {
938+
return NULL;
939+
}
966940
if (size == -1) {
967941
size = self->size - offset;
968942
}
969-
970943
if (size < 0 || offset < 0 || self->size - offset < size) {
971944
PyErr_SetString(PyExc_ValueError, "flush values out of range");
972945
return NULL;
@@ -1228,7 +1201,7 @@ static struct PyMethodDef mmap_object_methods[] = {
12281201
{"close", mmap_close_method, METH_NOARGS},
12291202
{"find", mmap_find_method, METH_VARARGS},
12301203
{"rfind", mmap_rfind_method, METH_VARARGS},
1231-
MMAP_MMAP_FLUSH_METHODDEF
1204+
{"flush", mmap_flush_method, METH_VARARGS},
12321205
#ifdef HAVE_MADVISE
12331206
{"madvise", mmap_madvise_method, METH_VARARGS},
12341207
#endif

0 commit comments

Comments
 (0)