You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use selectors instead of select.poll in sync.WebSocket Server for multi-platform support (#1349)
* use multiplatform selector instead of poll
* don't use os.pipe with the I/O multiplexing selector on win32
On the Win32 platform, only sockets can be used with I/O
multiplexing (such as that performed by selectors.DefaultSelector);
the pipe cannot be added to the selector. However, on the win32
platform, simply closing the listener socket is enough to cause the
call to select to return -- the additional pipe is redundant.
On Mac OS X (and possibly other BSD derivatives), closing the listener
socket isn't enough. In the interest of maximum compatibility, we
simply disable the use of os.pipe on the Win32 platform.
* exclude platform checks for win32 from coverage testing
0 commit comments