Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 31, 2020

Hello. Please tell me what I did wrong?
Why doesn't travic-ci check?

@ghost ghost mentioned this pull request Jul 31, 2020
@kvesteri
Copy link
Collaborator

kvesteri commented Aug 2, 2020

@daveusa31 There are flake8 and isort errors. You can see the errors in the travis report.

@ghost
Copy link
Author

ghost commented Aug 2, 2020

I'm sorry, but I couldn't figure it out :(

@kvesteri
Copy link
Collaborator

You can check the errors locally by first installing flake8 and isort

>> pip install isort
>> pip install flake8 

The you can run the following command for isort:

>> isort --recursive --diff validators tests && isort --recursive --check-only validators tests

And for flake8

flake8 validators tests

@ghost
Copy link
Author

ghost commented Aug 16, 2020

Yeah, it works



@validator
def btc_address(value):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a doc block here defining how this function is to be used. See other functions of similar doc blocks. Also reference this doc block in the index.rst file

@ghost
Copy link
Author

ghost commented Aug 17, 2020

Added

@kvesteri kvesteri merged commit 75dcaad into python-validators:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant