Skip to content

Wrong behavior of URL validator for domain with 2 dashes #187

@nitr0man

Description

@nitr0man

There is an error in URL validation when domain have two dashes. Domain validator passed such domains successfully.

In [1]: import validators                                                                                                                                                                                                                     

In [2]: validators.domain('foo-bar.com')                                                                                                                                                                                                      
Out[2]: True

In [3]: validators.domain('foo--bar.com')                                                                                                                                                                                                     
Out[3]: True

In [4]: validators.url('http://foo-bar.com')                                                                                                                                                                                                  
Out[4]: True

In [5]: validators.url('http://foo--bar.com')                                                                                                                                                                                                 
Out[5]: ValidationFailure(func=url, args={'value': 'http://foo--bar.com', 'public': False})

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue: Works not as designedduplicateIssue/PR: RedundantoutdatedIssue/PR: Open for more than 3 months

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions