Add flask 2 (<3.0) and flask 3 (>=3.0) to test matrix and do not fast fail #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 20 20
Lines 2756 2756
=======================================
Hits 2650 2650
Misses 106 106 ☔ View full report in Codecov by Sentry. |
Contributor
|
Great idea! Hopefully the team over at pytest-flask will have an updated version soon. We should probably leave this in going forwards for a bit to ensure we don't break backwards compatibility too anyways though! |
Contributor
Author
|
Looks like the problems with pytest-flask are solved since the Actions are succeeding 👍 |
|
@peter-doggart it looks like this is working, I hope it can be merged soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get more insight if our fixes are working for both flask version I created a test-matrix for flask 2 (<3.0.0) & flask 3 (>=3.0.0)