Make JSON errors more JS friendly and add response codes

Co-authored-by: Joe Banks <[email protected]>

Author: ks129

backend/routes/forms/new.py

@@ -29,7 +29,7 @@ async def post(self, request: Request) -> JSONResponse:
         if await request.state.db.forms.find_one({"_id": form.id}):
             return JSONResponse({
                 "error": "Form with same ID already exists."
-            })
+            }, status_code=400)
 
         await request.state.db.forms.insert_one(form.dict(by_alias=True))
         return JSONResponse(form.dict())

backend/routes/forms/submit.py

@@ -79,12 +79,12 @@ async def post(self, request: Request) -> JSONResponse:
 
                     if FormFeatures.COLLECT_EMAIL.value in form.features and "email" not in response["user"]:  # noqa
                         return JSONResponse({
-                            "error": "User data doesn't include email."
-                        })
+                            "error": "email_required"
+                        }, status_code=400)
                 else:
                     return JSONResponse({
-                        "error": "Missing Discord user data"
-                    })
+                        "error": "missing_discord_data"
+                    }, status_code=400)
 
             missing_fields = []
             for question in form.questions:
@@ -93,8 +93,9 @@ async def post(self, request: Request) -> JSONResponse:
 
             if missing_fields:
                 return JSONResponse({
-                    "error": f"Following missing fields: {', '.join(missing_fields)}."
-                })
+                    "error": "missing_fields",
+                    "fields": missing_fields
+                }, status_code=400)
 
             try:
                 response_obj = FormResponse(**response)