Skip to content

[xc-admin] permission accounts #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 17, 2023
Merged

[xc-admin] permission accounts #494

merged 16 commits into from
Jan 17, 2023

Conversation

@cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Jan 16, 2023 •
edited
Loading

  • add update permissions tab

@vercel
Copy link

vercel bot commented Jan 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
xc-admin-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 1:50AM (UTC)

@cctdaniel cctdaniel changed the title xc admin/permission accounts [xc-admin]/permission accounts Jan 16, 2023
@cctdaniel cctdaniel changed the title [xc-admin]/permission accounts [xc-admin] permission accounts Jan 16, 2023
@cctdaniel cctdaniel changed the base branch from main to xc-admin/rework-pyth-hook January 16, 2023 13:39
@cctdaniel cctdaniel marked this pull request as draft January 16, 2023 13:40
Base automatically changed from xc-admin/rework-pyth-hook to main January 16, 2023 19:14
@cctdaniel cctdaniel force-pushed the xc-admin/permission-accounts branch from 4570e0b to 52b063d Compare January 17, 2023 00:39
@cctdaniel cctdaniel marked this pull request as ready for review January 17, 2023 00:45
@cctdaniel cctdaniel requested a review from guibescos January 17, 2023 01:02
guibescos
guibescos reviewed Jan 17, 2023
View reviewed changes
guibescos
guibescos reviewed Jan 17, 2023
View reviewed changes
guibescos
guibescos approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic of tabs seems complicated, but there might be a reason why that I don't know

@cctdaniel cctdaniel force-pushed the xc-admin/permission-accounts branch from eec6bec to 8c7d5c7 Compare January 17, 2023 01:44
@cctdaniel cctdaniel merged commit 47c9993 into main Jan 17, 2023
@cctdaniel cctdaniel deleted the xc-admin/permission-accounts branch January 17, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guibescos guibescos guibescos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cctdaniel @guibescos