-
Notifications
You must be signed in to change notification settings - Fork 307
[price-service] add /get_vaa endpoint that serves cache and db vaas #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
reviewed
Jan 12, 2023
| if ( | ||
| publishTime < | ||
| Math.floor(Date.now() / 1000) - | ||
| PYTH_WRITER_INSERT_LATENCY_SECONDS || |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think injecting pyth writer logic be good here. The check seems unnecessary to me.
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 12, 2023
ali-behjati
reviewed
Jan 13, 2023
ali-behjati
reviewed
Jan 13, 2023
ali-behjati
reviewed
Jan 13, 2023
ali-behjati
reviewed
Jan 13, 2023
ali-behjati
approved these changes
Jan 13, 2023
Collaborator
ali-behjati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it ser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generally:
publishTimeandvaa(VAAs are stored in an ascending order based onpublishTime)publishTime, we can run binary search on the array to find the publishTime greater than or equal to the target on O(logn) timepublishTimethat has expired will be removed from the cacheother considerations: