Skip to content

Conversation

@aditya520
Copy link
Member

Summary

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@aditya520 aditya520 requested a review from a team as a code owner August 27, 2025 19:02
@vercel
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
api-reference Ready Ready Preview Comment Sep 2, 2025 5:38pm
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
component-library Skipped Skipped Sep 2, 2025 5:38pm
developer-hub Skipped Skipped Sep 2, 2025 5:38pm
entropy-explorer Skipped Skipped Sep 2, 2025 5:38pm
insights Skipped Skipped Sep 2, 2025 5:38pm
proposals Skipped Skipped Sep 2, 2025 5:38pm
staking Skipped Skipped Sep 2, 2025 5:38pm

Comment on lines +56 to +57
defaultValue:
"0x504e41550100000003b801000000040d00cea20e5677f66ed178e9410ddd8280617c06921916e8fd4b71e597d7f6c6d0a14daf3bb3e1a0d8c9e051c8d0................",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious whats this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updateData / signed message/ VAA from our hermes. This is just a hardcoded example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we add a comment in the code ?

@vercel vercel bot temporarily deployed to Preview – staking August 28, 2025 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – insights August 28, 2025 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub August 28, 2025 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals August 28, 2025 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer August 28, 2025 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library August 28, 2025 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer August 28, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – staking August 28, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – insights August 28, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals August 28, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub August 28, 2025 18:00 Inactive
@aditya520 aditya520 requested a review from alexcambose August 28, 2025 18:00
@vercel vercel bot temporarily deployed to Preview – component-library August 28, 2025 18:00 Inactive
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing, due to formatting. Pls check.

@aditya520 aditya520 enabled auto-merge (squash) September 2, 2025 17:18
@aditya520 aditya520 force-pushed the chore(api-reference)-fix-input-feilds branch from 9e2b162 to e458dcc Compare September 2, 2025 17:35
@vercel vercel bot temporarily deployed to Preview – staking September 2, 2025 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library September 2, 2025 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub September 2, 2025 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals September 2, 2025 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer September 2, 2025 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – insights September 2, 2025 17:35 Inactive
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a nit to add comments for updateData.

@aditya520 aditya520 merged commit 08f2c37 into main Sep 3, 2025
10 checks passed
@aditya520 aditya520 deleted the chore(api-reference)-fix-input-feilds branch September 3, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants