refactor(stylus): dividing governance instructions out of lib.rs #2889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract governance-related functionality into separate governance.rs module - Keep all pyth operations in lib.rs as requested - Maintain idiomatic Rust module organization - All code compiles successfully with only minor warnings Co-Authored-By: [email protected] <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tejasbadadare
approved these changes
Jul 23, 2025
Contributor
tejasbadadare
left a comment
tejasbadadare
left a comment
There was a problem hiding this comment.
pls address before merging, thx!
Comment on lines
604
to
605
| // Stylus doesn't provide a way to mock up the testing timestamp | ||
| // so at the moment I'm using the testing trait to let me test old timestamps |
Contributor
There was a problem hiding this comment.
Looks like devin chopped some comments? Lets keep these in
| check_uniqueness: bool, | ||
| ) -> Result<Vec<PriceFeedReturn>, PythReceiverError> { | ||
| let update_data_array: &[u8] = &update_data; | ||
| // Check the first 4 bytes of the update_data_array for the magic header |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dividing governance instructions out of lib.rs
How has this been tested?