add support to configure max latency #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cctdaniel
commented
Feb 15, 2024
| uint8_t min_pub_; // min publishers for valid price | ||
| int8_t drv2_; // space for future derived values | ||
| int16_t drv3_; // space for future derived values | ||
| int8_t message_sent_; // flag to indicate if the current aggregate price has been sent as a message to the message buffer, 0 if not sent, 1 if sent |
Contributor
Author
There was a problem hiding this comment.
drive-by: this was already changed in the rust program previously but wasn't changed here
cctdaniel
commented
Feb 15, 2024
| int8_t drv2_; // space for future derived values | ||
| int16_t drv3_; // space for future derived values | ||
| int8_t message_sent_; // flag to indicate if the current aggregate price has been sent as a message to the message buffer, 0 if not sent, 1 if sent | ||
| uint8_t max_latency_; // configurable max latency in slots between send and receive |
Contributor
Author
There was a problem hiding this comment.
we only need uint8_t for max_latency_ so splitting it to uint8_t and int8_t
cctdaniel
force-pushed
the
max-latency
branch
from
ceeada2 to
74c6366
Compare
cctdaniel
changed the title
cctdaniel
changed the title
guibescos
reviewed
Feb 19, 2024
guibescos
reviewed
Feb 19, 2024
guibescos
reviewed
Feb 19, 2024
guibescos
reviewed
Feb 19, 2024
guibescos
reviewed
Feb 19, 2024
guibescos
reviewed
Feb 19, 2024
ali-behjati
reviewed
Feb 19, 2024
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Very nice! I will look again after you addressed the feedbacks (just to be extra careful).
guibescos
reviewed
Feb 20, 2024
guibescos
reviewed
Feb 20, 2024
guibescos
reviewed
Feb 20, 2024
guibescos
previously approved these changes
Feb 20, 2024
guibescos
previously approved these changes
Feb 20, 2024
ali-behjati
reviewed
Feb 21, 2024
ali-behjati
approved these changes
Feb 21, 2024
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Nice! I left some minor comments.
ali-behjati
previously approved these changes
Feb 21, 2024
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Nice! I left some minor comments.
ali-behjati
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add configurable max latency in slots between send and receive
for price feeds with more publishers this can be reduced instead of using the default 25 value to reduce latency