Skip to content

Cleanup resize, remove print staments, add extra check #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

Cleanup resize, remove print staments, add extra check #272

merged 1 commit into from
Aug 25, 2022

Conversation

@guibescos
Copy link
Contributor

@guibescos guibescos commented Aug 24, 2022

This PR:

  • Cleans up the comments in resize_price_account
  • Adds an extra rent exemption check to make sure the lamport transfer worked (paranoid check)
  • Removes print statements.

tompntn
tompntn approved these changes Aug 25, 2022
View reviewed changes
program/rust/src/time_machine_types.rs
impl PriceAccountWrapper {
pub fn initialize_time_machine(&mut self) -> Result<(), OracleError> {
msg!("implement me");
// TO DO
Copy link
Contributor

@tompntn tompntn Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the todo!() macro here.

@guibescos guibescos merged commit 36bae1a into main Aug 25, 2022
@guibescos guibescos deleted the cleanup-resize-price branch August 25, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tompntn tompntn tompntn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guibescos @tompntn