Move minimum size check to load_checked and initialize_checked #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
force-pushed
the
use-minimum-size
branch
2 times, most recently
from
21922b5 to
8ff86c7
Compare
guibescos
changed the title
guibescos
commented
Aug 26, 2022
| /// Get the data stored in `account` as a value of type `T` | ||
| /// /// Warning: DON'T USE THIS UNCHECKED FUNCTION | ||
| pub fn load_account_as<'a, T: Pod>(account: &'a AccountInfo) -> Result<Ref<'a, T>, ProgramError> { | ||
| let data = account.try_borrow_data()?; |
Contributor
Author
There was a problem hiding this comment.
I want to make this private but it'll require some more refactoring.
guibescos
force-pushed
the
use-minimum-size
branch
from
3740528 to
2e4446d
Compare
guibescos
changed the title
jayantk
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimum_sizecheck toload_checkedandinitialize_checkedfromcheck_valid_signable_accountandcheck_valid_writable_account. This allows to leverage the PythAccount trait for the check. It makes sense to have that check in the deserialization functions because if the account is too small deserialization will fail.check_valid_fresh_accounttoinitialize_pyth_account_checked. These two functions are always called together. Makes it harder to accidentally reinitialize an account.