Batch updates in update_price JRPC call #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
reviewed
Jan 24, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
Seems reasonable to me. My C++ is terrible though, so would be good to let david look as well.
Main question is what's our testing strategy?
jhunsaker
reviewed
Jan 25, 2022
…ly, instead of immediately sending them
tompntn
force-pushed
the
batching
branch
4 times, most recently
from
dec0217 to
1a5f77e
Compare
Reisen
reviewed
Feb 2, 2022
Reisen
previously approved these changes
Feb 2, 2022
jayantk
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the semantics of the
update_pricepythd JRPC call. Previously, updates were immediately sent to Solana (orpyth_tx) using a new transaction for each update. Instead, we buffer all received updates inside pythd, and send all buffered updates in bulk whenever a new slot is available. This uses less transactions at a cost of slightly increased latency.I have tried to follow existing code styles and conventions as much as possible.
A follow-up PR will modify the on-chain program, adding a batch update endpoint which will only fail the transaction if all the individual price updates in that batch fail. This will ensure publishing failures on one product won't block updates for unaffected products.