Enable governance by master authority (#308)

* Update master key to be able to perform all admin actions

* Update tests

* Update error for unauthorized publisher

* Fix CI

Author: guibescos

program/rust/src/accounts/permission.rs

@@ -45,7 +45,7 @@ impl PermissionAccount {
     pub fn is_authorized(&self, key: &Pubkey, command: OracleCommand) -> bool {
         #[allow(clippy::match_like_matches_macro)]
         match (*key, command) {
-            (pubkey, OracleCommand::InitMapping) if pubkey == self.master_authority => true,
+            (pubkey, _) if pubkey == self.master_authority => true,
             _ => false,
         }
     }

program/rust/src/processor/upd_price.rs

@@ -96,7 +96,7 @@ pub fn upd_price(
         }
         pyth_assert(
             publisher_index < try_convert::<u32, usize>(price_data.num_)?,
-            ProgramError::InvalidArgument,
+            OracleError::PermissionViolation.into(),
         )?;
 
 

program/rust/src/tests/test_permission_migration.rs

@@ -82,10 +82,9 @@ fn test_permission_migration() {
             &[
                 attacker_account.clone(),
                 mapping_account.clone(),
-                next_mapping_account.clone(),
                 permissions_account.clone()
             ],
-            bytes_of::<CommandHeader>(&AddMapping.into())
+            bytes_of::<CommandHeader>(&InitMapping.into())
         ),
         Err(OracleError::PermissionViolation.into())
     );
@@ -106,7 +105,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 mapping_account.clone(),
                 next_mapping_account.clone(),
                 permissions_account.clone()
@@ -120,7 +119,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 mapping_account.clone(),
                 product_account.clone(),
                 permissions_account.clone()
@@ -134,7 +133,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 product_account.clone(),
                 permissions_account.clone()
             ],
@@ -147,7 +146,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 product_account.clone(),
                 price_account.clone(),
                 permissions_account.clone()
@@ -165,7 +164,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 price_account.clone(),
                 permissions_account.clone()
             ],
@@ -182,7 +181,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 price_account.clone(),
                 permissions_account.clone()
             ],
@@ -198,7 +197,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 price_account.clone(),
                 permissions_account.clone()
             ],
@@ -214,7 +213,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 price_account.clone(),
                 permissions_account.clone()
             ],
@@ -231,7 +230,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 price_account.clone(),
                 price_account.clone(), // Mock system program
                 permissions_account.clone()
@@ -245,7 +244,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 product_account.clone(),
                 price_account.clone(),
                 permissions_account.clone()
@@ -259,7 +258,7 @@ fn test_permission_migration() {
         process_instruction(
             &program_id,
             &[
-                funding_account.clone(),
+                attacker_account.clone(),
                 mapping_account.clone(),
                 product_account.clone(),
                 permissions_account.clone()

program/rust/src/tests/test_upd_price_no_fail_on_error.rs

@@ -13,6 +13,7 @@ use {
             load_checked,
             load_mut,
         },
+        error::OracleError,
         instruction::{
             OracleCommand,
             UpdPriceArgs,
@@ -65,7 +66,7 @@ fn test_upd_price_no_fail_on_error_no_fail_on_error() {
             ],
             &instruction_data
         ),
-        Err(ProgramError::InvalidArgument)
+        Err(OracleError::PermissionViolation.into())
     );