Fix asserts clippy

Author: guibescos

program/rust/src/lib.rs

@@ -1,8 +1,6 @@
 #![deny(warnings)]
 // Allow non upper case globals from C
 #![allow(non_upper_case_globals)]
-#![allow(incomplete_features)]
-#![allow(clippy::bool_assert_comparison)]
 
 mod c_oracle_header;
 mod deserialize;

program/rust/src/tests/test_sma_epoch_transition.rs

@@ -87,7 +87,7 @@ fn test_sma_epoch_transition() {
         );
         assert_eq!(price_data.time_machine.granularity, THIRTY_MINUTES);
         assert_eq!(price_data.time_machine.current_epoch_numerator, 0);
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 0);
         for i in 0..NUM_BUCKETS_THIRTY_MIN {
             assert_eq!(price_data.time_machine.running_sum_of_price_averages[i], 0);
@@ -120,7 +120,7 @@ fn test_sma_epoch_transition() {
         );
         assert_eq!(price_data.time_machine.granularity, THIRTY_MINUTES);
         assert_eq!(price_data.time_machine.current_epoch_numerator, 42 / 2 * 2);
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 2);
         for i in 0..NUM_BUCKETS_THIRTY_MIN {
             assert_eq!(price_data.time_machine.running_sum_of_price_averages[i], 0);
@@ -157,7 +157,7 @@ fn test_sma_epoch_transition() {
             price_data.time_machine.current_epoch_numerator,
             (80 + 42) / 2
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, true);
+        assert!(price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 1);
 
         for i in 1..NUM_BUCKETS_THIRTY_MIN {
@@ -201,7 +201,7 @@ fn test_sma_epoch_transition() {
             price_data.time_machine.current_epoch_numerator,
             (80 + 42) / 2
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, true);
+        assert!(price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 1);
 
         for i in 1..NUM_BUCKETS_THIRTY_MIN {
@@ -246,7 +246,7 @@ fn test_sma_epoch_transition() {
             price_data.time_machine.current_epoch_numerator,
             (40 + 80) / 2 * 28
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 28);
 
         for i in 2..NUM_BUCKETS_THIRTY_MIN {
@@ -297,7 +297,7 @@ fn test_sma_epoch_transition() {
             price_data.time_machine.current_epoch_numerator,
             (40 + 41) / 2
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, true);
+        assert!(price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 1);
 
         for i in 5..NUM_BUCKETS_THIRTY_MIN {
@@ -367,7 +367,7 @@ fn test_sma_epoch_transition() {
             price_data.time_machine.current_epoch_numerator,
             (40 + 41) / 2
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, true);
+        assert!(price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 1);
 
         for i in 5..NUM_BUCKETS_THIRTY_MIN {
@@ -434,7 +434,7 @@ fn test_sma_epoch_transition() {
             price_data.time_machine.current_epoch_numerator,
             (41 + 100) / 2 * 69
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 69);
         for i in 0..NUM_BUCKETS_THIRTY_MIN {
             assert_eq!(

program/rust/src/tests/test_upd_sma.rs

@@ -94,7 +94,7 @@ fn test_upd_sma() {
         assert_eq!(price_data.price_data.agg_.status_, PC_STATUS_UNKNOWN);
 
         assert_eq!(price_data.time_machine.current_epoch_numerator, 0);
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 0);
     }
 
@@ -129,7 +129,7 @@ fn test_upd_sma() {
         assert_eq!(price_data.price_data.agg_.status_, PC_STATUS_UNKNOWN);
 
         assert_eq!(price_data.time_machine.current_epoch_numerator, 0);
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 0);
     }
 
@@ -163,7 +163,7 @@ fn test_upd_sma() {
         assert_eq!(price_data.price_data.agg_.status_, PC_STATUS_TRADING);
 
         assert_eq!(price_data.time_machine.current_epoch_numerator, 42 / 2 * 3);
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 3);
     }
 
@@ -199,7 +199,7 @@ fn test_upd_sma() {
             price_data.time_machine.current_epoch_numerator,
             42 / 2 * 3 + (81 + 42) / 2
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 3 + 1);
     }
 
@@ -235,7 +235,7 @@ fn test_upd_sma() {
             price_data.time_machine.current_epoch_numerator,
             42 / 2 * 3 + (81 + 42) / 2 + 81
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 3 + 1 + 1);
     }
 
@@ -273,7 +273,7 @@ fn test_upd_sma() {
             price_data.time_machine.current_epoch_numerator,
             42 / 2 * 3 + (81 + 42) / 2 + 81
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(price_data.time_machine.current_epoch_denominator, 3 + 1 + 1);
     }
 
@@ -320,7 +320,7 @@ fn test_upd_sma() {
             price_data.time_machine.current_epoch_numerator,
             42 / 2 * 3 + (81 + 42) / 2 + 81 + 81
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(
             price_data.time_machine.current_epoch_denominator,
             3 + 1 + 1 + 1
@@ -360,7 +360,7 @@ fn test_upd_sma() {
             price_data.time_machine.current_epoch_numerator,
             42 / 2 * 3 + (81 + 42) / 2 + 81 + 81
         );
-        assert_eq!(price_data.time_machine.current_epoch_is_valid, false);
+        assert!(!price_data.time_machine.current_epoch_is_valid);
         assert_eq!(
             price_data.time_machine.current_epoch_denominator,
             3 + 1 + 1 + 1