Add test for update_price JPRC call

Author: tompntn

docker/Dockerfile

@@ -16,6 +16,7 @@ RUN apt-get install -qq \
   libzstd1 \
   libzstd-dev \
   python3-pytest \
+  python3-pytest-asyncio \
   python3-websockets \
   sudo \
   zlib1g \

pc/request.cpp

@@ -773,7 +773,7 @@ bool price::send( price *prices[], const unsigned n )
             std::string( 100, '\0' ), p1->preq_->get_sent_time()
           );
           p1->preq_->get_signature()->enc_base58( p1->tvec_.back().first );
-          PC_LOG_DBG( "sent price update transaction" )
+          PC_LOG_DBG( "sent price update" )
             .add( "price_account", *p1->get_account() )
             .add( "product_account", *p1->prod_->get_account() )
             .add( "symbol", p1->get_symbol() )

pyth/tests/conftest.py

@@ -347,12 +347,12 @@ def pythd(solana_test_validator, pyth_dir):
         '-x',
         '-m', 'finalized',
         '-d',
+        '-l', 'pyth_logs.txt',
     ]
     kwargs = {
         'stdin': DEVNULL,
-        'stdout': DEVNULL,
-        'stderr': DEVNULL,
     }
+        
     with Popen(cmd, **kwargs) as p:
         time.sleep(3)
         yield

pyth/tests/test_update_price.py

@@ -0,0 +1,118 @@
+import json
+from subprocess import check_output
+import pytest
+import websockets
+import time
+import itertools
+import random
+
+from pyth.tests.conftest import PRODUCTS
+
+@pytest.mark.asyncio
+async def test_batch_update_price(solana_test_validator, pythd, pyth_dir, pyth_init_product, pyth_init_price):
+
+    messageIds = itertools.count()
+
+    # Use a single websocket connection for the entire test, as batching is done per-user
+    async with websockets.connect('ws://localhost:8910/') as ws:
+
+        async def update_price(account, price, conf, status):
+            msg = jrpc_req(
+                method='update_price',
+                params={
+                    'account': account,
+                    'price': price,
+                    'conf': conf,
+                    'status': status,
+                })
+
+            await send(msg)
+            resp = await recv()
+            assert resp['result'] == 0
+
+        async def get_product(account):
+            output = check_output([
+                'pyth', 'get_product',
+                account,
+                '-r', 'localhost',
+                '-k', pyth_dir,
+                '-c', 'finalized',
+                '-j',
+            ]).decode('ascii')
+            result = json.loads(output)
+
+            return result
+
+        def jrpc_req(method=None, params=None):
+            return {
+                'jsonrpc': '2.0',
+                'method': method,
+                'params': params,
+                'id': next(messageIds)
+            }
+
+        async def send(msg):
+            print("--- sending message ---")
+            print(msg)
+            await ws.send(json.dumps(msg))
+
+        async def recv():
+            data = await ws.recv()
+            msg = json.loads(data)
+            print("----- received message -----")
+            print(msg)
+            return msg
+
+        def get_publisher_acc(product_acc):
+            assert len(product_acc['price_accounts']) == 1
+            price_acc = product_acc['price_accounts'][0]
+
+            assert len(price_acc['publisher_accounts']) == 1
+            return price_acc['publisher_accounts'][0]
+
+        # Check that the prices are 0 initially
+        for product in PRODUCTS.keys():
+            product_acc = await get_product(pyth_init_product[product])
+            publisher_acc = get_publisher_acc(product_acc)
+
+            assert publisher_acc['price'] == 0
+            assert publisher_acc['conf'] == 0
+            assert publisher_acc['status'] == 'unknown'
+
+        # Generate new values for this test
+        new_values = {
+            product: {
+                'price':random.randint(1, 150),
+                'conf': random.randint(1, 20),
+                'status': 'trading',
+            } for product in PRODUCTS.keys()
+        }
+
+        # Update the values of the products
+        for product in PRODUCTS.keys():
+            await update_price(
+                pyth_init_price[product],
+                new_values[product]['price'],
+                new_values[product]['conf'],
+                new_values[product]['status'])
+
+        time.sleep(80)
+
+        # Crank the products
+        for product in PRODUCTS.keys():
+            await update_price(
+                pyth_init_price[product],
+                1,
+                1,
+                'trading')
+
+        time.sleep(80)
+
+        # Check that the price has been updated
+        for product in PRODUCTS.keys():
+            product_acc = await get_product(pyth_init_product[product])
+            publisher_acc = get_publisher_acc(product_acc)
+
+            assert publisher_acc['price'] == new_values[product]['price']
+            assert publisher_acc['conf'] == new_values[product]['conf']
+            assert publisher_acc['status'] == new_values[product]['status']