Skip to content

Commit 490e658

Browse files
committed
address comments
1 parent 49cf2b9 commit 490e658

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

program/rust/src/tests/test_upd_price.rs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ fn test_upd_price() {
8080
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 1);
8181
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
8282
assert_eq!(price_data.valid_slot_, 0);
83+
assert_eq!(price_data.last_slot_, 1);
8384
assert_eq!(price_data.agg_.pub_slot_, 1);
8485
assert_eq!(price_data.agg_.price_, 42);
8586
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
@@ -112,6 +113,7 @@ fn test_upd_price() {
112113
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 1);
113114
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
114115
assert_eq!(price_data.valid_slot_, 0);
116+
assert_eq!(price_data.last_slot_, 1);
115117
assert_eq!(price_data.agg_.pub_slot_, 1);
116118
assert_eq!(price_data.agg_.price_, 42);
117119
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
@@ -143,6 +145,7 @@ fn test_upd_price() {
143145
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 2);
144146
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
145147
assert_eq!(price_data.valid_slot_, 1);
148+
assert_eq!(price_data.last_slot_, 3);
146149
assert_eq!(price_data.agg_.pub_slot_, 3);
147150
assert_eq!(price_data.agg_.price_, 81);
148151
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
@@ -174,13 +177,14 @@ fn test_upd_price() {
174177
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 3);
175178
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
176179
assert_eq!(price_data.valid_slot_, 3);
180+
assert_eq!(price_data.last_slot_, 4);
177181
assert_eq!(price_data.agg_.pub_slot_, 4);
178182
assert_eq!(price_data.agg_.price_, 81);
179183
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
180184
assert_eq!(price_data.prev_slot_, 3);
181185
assert_eq!(price_data.prev_price_, 81);
182186
assert_eq!(price_data.prev_conf_, 2);
183-
assert_eq!(price_data.timestamp_, 4); // We only check for timestamp_ here because test_upd_price doesn't directly update timestamp_, this is updated through c_upd_aggregate which is tested in test_upd_aggregate, but we assert here to show that in subsequent asserts for prev_tim
187+
assert_eq!(price_data.timestamp_, 4); // We only check for timestamp_ here because test_upd_price doesn't directly update timestamp_, this is updated through c_upd_aggregate which is tested in test_upd_aggregate, but we assert here to show that in subsequent asserts for prev_timestamp_ the value should be updated to this value
184188
assert_eq!(price_data.prev_timestamp_, 1);
185189
}
186190

@@ -205,6 +209,7 @@ fn test_upd_price() {
205209
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 4);
206210
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
207211
assert_eq!(price_data.valid_slot_, 4);
212+
assert_eq!(price_data.last_slot_, 5);
208213
assert_eq!(price_data.agg_.pub_slot_, 5);
209214
assert_eq!(price_data.agg_.price_, 81);
210215
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
@@ -237,6 +242,7 @@ fn test_upd_price() {
237242
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 4);
238243
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
239244
assert_eq!(price_data.valid_slot_, 4);
245+
assert_eq!(price_data.last_slot_, 5);
240246
assert_eq!(price_data.agg_.pub_slot_, 5);
241247
assert_eq!(price_data.agg_.price_, 81);
242248
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
@@ -275,6 +281,7 @@ fn test_upd_price() {
275281
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 5);
276282
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_IGNORED);
277283
assert_eq!(price_data.valid_slot_, 5);
284+
assert_eq!(price_data.last_slot_, 5);
278285
assert_eq!(price_data.agg_.pub_slot_, 6);
279286
assert_eq!(price_data.agg_.price_, 81);
280287
assert_eq!(price_data.agg_.status_, PC_STATUS_UNKNOWN);
@@ -305,6 +312,7 @@ fn test_upd_price() {
305312
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 7);
306313
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
307314
assert_eq!(price_data.valid_slot_, 6);
315+
assert_eq!(price_data.last_slot_, 8);
308316
assert_eq!(price_data.agg_.pub_slot_, 8);
309317
assert_eq!(price_data.agg_.price_, -100);
310318
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
@@ -341,6 +349,7 @@ fn test_upd_price() {
341349
assert_eq!(price_data.comp_[0].latest_.pub_slot_, 10);
342350
assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_TRADING);
343351
assert_eq!(price_data.valid_slot_, 8);
352+
assert_eq!(price_data.last_slot_, 10);
344353
assert_eq!(price_data.agg_.pub_slot_, 10);
345354
assert_eq!(price_data.agg_.price_, 10);
346355
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
@@ -377,6 +386,7 @@ fn test_upd_price() {
377386
assert_eq!(price_data.comp_[1].latest_.pub_slot_, 10);
378387
assert_eq!(price_data.comp_[1].latest_.status_, PC_STATUS_TRADING);
379388
assert_eq!(price_data.valid_slot_, 8);
389+
assert_eq!(price_data.last_slot_, 10);
380390
assert_eq!(price_data.agg_.pub_slot_, 10);
381391
assert_eq!(price_data.agg_.price_, 10);
382392
assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);

0 commit comments

Comments
 (0)