Updated clippy config (#170)

Author: merolish

Cargo.toml

@@ -66,3 +66,43 @@ panic = 'abort'
 
 [profile.dev]
 panic = 'abort'
+
+[lints.rust]
+unsafe_code = "deny"
+
+[lints.clippy]
+wildcard_dependencies = "deny"
+
+collapsible_if = "allow"
+collapsible_else_if = "allow"
+
+allow_attributes_without_reason = "warn"
+
+# Panics
+expect_used = "warn"
+fallible_impl_from = "warn"
+indexing_slicing = "warn"
+panic = "warn"
+panic_in_result_fn = "warn"
+string_slice = "warn"
+todo = "warn"
+unchecked_duration_subtraction = "warn"
+unreachable = "warn"
+unwrap_in_result = "warn"
+unwrap_used = "warn"
+
+# Correctness
+cast_lossless = "warn"
+cast_possible_truncation = "warn"
+cast_possible_wrap = "warn"
+cast_sign_loss = "warn"
+collection_is_never_read = "warn"
+match_wild_err_arm = "warn"
+path_buf_push_overwrite = "warn"
+read_zero_byte_vec = "warn"
+same_name_method = "warn"
+suspicious_operation_groupings = "warn"
+suspicious_xor_used_as_pow = "warn"
+unused_self = "warn"
+used_underscore_binding = "warn"
+while_float = "warn"

clippy.toml

@@ -0,0 +1,4 @@
+allow-unwrap-in-tests = true
+allow-expect-in-tests = true
+allow-indexing-slicing-in-tests = true
+allow-panic-in-tests = true

rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.86.0"
+channel = "1.88.0"
 profile = "minimal"
 components = ["rustfmt", "clippy"]

src/agent/legacy_schedule.rs

@@ -1,5 +1,5 @@
 //! Market hours metadata parsing and evaluation logic
-#![allow(deprecated)]
+#![allow(deprecated, reason = "publishers depend on legacy schedule")]
 
 use {
     anyhow::{
@@ -46,6 +46,7 @@ pub struct LegacySchedule {
     pub sun:      MHKind,
 }
 
+#[allow(deprecated, reason = "publishers depend on legacy schedule")]
 impl LegacySchedule {
     pub fn all_closed() -> Self {
         Self {
@@ -93,7 +94,7 @@ impl FromStr for LegacySchedule {
             .trim()
             .parse()
             .map_err(|e: ParseError| anyhow!(e))
-            .context(format!("Could parse timezone from {:?}", tz_str))?;
+            .context(format!("Could parse timezone from {tz_str:?}"))?;
 
         let mut weekday_schedules = Vec::with_capacity(7);
 
@@ -112,8 +113,7 @@ impl FromStr for LegacySchedule {
             ))?;
 
             let mhkind: MHKind = mhkind_str.trim().parse().context(format!(
-                "Could not parse {} field from {:?}",
-                weekday, mhkind_str
+                "Could not parse {weekday} field from {mhkind_str:?}",
             ))?;
 
             weekday_schedules.push(mhkind);
@@ -225,6 +225,7 @@ impl FromStr for MHKind {
 }
 
 #[cfg(test)]
+#[allow(clippy::panic_in_result_fn, reason = "")]
 mod tests {
     use {
         super::*,

src/agent/market_schedule.rs

@@ -1,6 +1,6 @@
 //! Holiday hours metadata parsing and evaluation logic
 
-#[allow(deprecated)]
+#[allow(deprecated, reason = "publishers depend on legacy schedule")]
 use {
     super::legacy_schedule::{
         LegacySchedule,
@@ -68,14 +68,14 @@ impl Display for MarketSchedule {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         write!(f, "{};", self.timezone)?;
         for (i, day) in self.weekly_schedule.iter().enumerate() {
-            write!(f, "{}", day)?;
+            write!(f, "{day}")?;
             if i < 6 {
                 write!(f, ",")?;
             }
         }
         write!(f, ";")?;
         for (i, holiday) in self.holidays.iter().enumerate() {
-            write!(f, "{}", holiday)?;
+            write!(f, "{holiday}")?;
             if i < self.holidays.len() - 1 {
                 write!(f, ",")?;
             }
@@ -131,7 +131,7 @@ impl FromStr for MarketSchedule {
     }
 }
 
-#[allow(deprecated)]
+#[allow(deprecated, reason = "publishers still depend on legacy schedule")]
 impl From<LegacySchedule> for MarketSchedule {
     fn from(legacy: LegacySchedule) -> Self {
         Self {
@@ -283,6 +283,7 @@ impl From<MHKind> for ScheduleDayKind {
 }
 
 #[cfg(test)]
+#[allow(clippy::panic_in_result_fn, reason = "")]
 mod tests {
     use {
         super::*,
@@ -604,7 +605,7 @@ mod tests {
 
         #[test]
         fn parse_valid_holiday_day_schedule(s in VALID_SCHEDULE_DAY_KIND_REGEX, d in VALID_MONTH_DAY_REGEX) {
-            let valid_holiday_day = format!("{}/{}", d, s);
+            let valid_holiday_day = format!("{d}/{s}");
             assert!(valid_holiday_day.parse::<HolidayDaySchedule>().is_ok());
         }
 

src/agent/metrics.rs

@@ -35,6 +35,7 @@ use {
 };
 
 pub fn default_bind_address() -> SocketAddr {
+    #[allow(clippy::unwrap_used, reason = "hardcoded value valid")]
     "127.0.0.1:8888".parse().unwrap()
 }
 
@@ -63,7 +64,7 @@ pub async fn spawn(addr: impl Into<SocketAddr> + 'static) {
         .and(warp::path::end())
         .and_then(move || async move {
             let mut buf = String::new();
-            #[allow(clippy::needless_borrow)]
+            #[allow(clippy::needless_borrow, reason = "false positive")]
             let response = encode(&mut buf, &&PROMETHEUS_REGISTRY.lock().await)
                 .map_err(|e| -> Box<dyn std::error::Error> { e.into() })
                 .map(|_| Box::new(reply::with_status(buf, StatusCode::OK)))
@@ -118,7 +119,7 @@ impl ProductGlobalMetrics {
     pub fn update(&self, product_key: &Pubkey, maybe_symbol: Option<SmolStr>) {
         let symbol_string = maybe_symbol
             .map(|x| x.into())
-            .unwrap_or(format!("unknown_{}", product_key));
+            .unwrap_or(format!("unknown_{product_key}"));
 
         #[deny(unused_variables)]
         let Self { update_count } = self;
@@ -248,7 +249,7 @@ impl PriceGlobalMetrics {
         expo.get_or_create(&PriceGlobalLabels {
             pubkey: price_key.to_string(),
         })
-        .set(price_account.expo as i64);
+        .set(i64::from(price_account.expo));
 
         conf.get_or_create(&PriceGlobalLabels {
             pubkey: price_key.to_string(),

src/agent/pyth/rpc.rs

@@ -170,7 +170,7 @@ async fn handle_connection<S>(
     }
 }
 
-#[allow(clippy::too_many_arguments)]
+#[allow(clippy::too_many_arguments, reason = "")]
 async fn handle_next<S>(
     state: &S,
     ws_tx: &mut SplitSink<WebSocket, Message>,
@@ -266,6 +266,10 @@ where
             if is_batch {
                 feed_text(ws_tx, &serde_json::to_string(&responses)?).await?;
             } else {
+                #[allow(
+                    clippy::indexing_slicing,
+                    reason = "single response guaranteed to have one item"
+                )]
                 feed_text(ws_tx, &serde_json::to_string(&responses[0])?).await?;
             }
         }

src/agent/services/exporter.rs

@@ -210,7 +210,7 @@ where
     handles
 }
 
-#[allow(clippy::module_inception)]
+#[allow(clippy::module_inception, reason = "")]
 mod exporter {
     use {
         super::NetworkState,

src/agent/services/keypairs.rs

@@ -38,6 +38,7 @@ use {
 const DEFAULT_MIN_KEYPAIR_BALANCE_SOL: u64 = 1;
 
 pub fn default_bind_address() -> SocketAddr {
+    #[allow(clippy::expect_used, reason = "hardcoded value valid")]
     "127.0.0.1:9001"
         .parse()
         .expect("INTERNAL: Could not build default remote keypair loader bind address")

src/agent/services/lazer_exporter.rs

@@ -282,6 +282,7 @@ fn get_signing_key(config: &Config) -> Result<SigningKey> {
 pub fn lazer_exporter(config: Config, state: Arc<state::State>) -> Vec<JoinHandle<()>> {
     let mut handles = vec![];
 
+    #[allow(clippy::panic, reason = "agent can't work without keypair")]
     let signing_key = match get_signing_key(&config) {
         Ok(signing_key) => signing_key,
         Err(e) => {
@@ -324,7 +325,7 @@ pub fn lazer_exporter(config: Config, state: Arc<state::State>) -> Vec<JoinHandl
     handles
 }
 
-#[allow(clippy::module_inception)]
+#[allow(clippy::module_inception, reason = "")]
 mod lazer_exporter {
     use {
         crate::agent::{
@@ -381,6 +382,7 @@ mod lazer_exporter {
         S: LocalStore,
         S: Send + Sync + 'static,
     {
+        #[allow(clippy::panic, reason = "lazer exporter can't work without symbols")]
         // We can't publish to Lazer without symbols, so crash the process if it fails.
         let mut lazer_symbols = match get_lazer_symbol_map(&config.history_url).await {
             Ok(symbol_map) => {
@@ -435,6 +437,7 @@ mod lazer_exporter {
                             let source_timestamp_micros = price_info.timestamp.and_utc().timestamp_micros();
                             let source_timestamp = MessageField::some(Timestamp {
                                 seconds: source_timestamp_micros / 1_000_000,
+                                #[allow(clippy::cast_possible_truncation, reason = "value is always less than one billion")]
                                 nanos: (source_timestamp_micros % 1_000_000 * 1000) as i32,
                                 special_fields: Default::default(),
                             });
@@ -710,7 +713,7 @@ mod tests {
         let mut temp_file = NamedTempFile::new().unwrap();
         temp_file
             .as_file_mut()
-            .write(private_key_string.as_bytes())
+            .write_all(private_key_string.as_bytes())
             .unwrap();
         temp_file.flush().unwrap();
         temp_file
@@ -758,8 +761,8 @@ mod tests {
         .unwrap();
         let price = PriceInfo {
             status:    PriceStatus::Trading,
-            price:     100_000_00000000i64,
-            conf:      1_00000000u64,
+            price:     10_000_000_000_000i64,
+            conf:      100_000_000u64,
             timestamp: Default::default(),
         };
         state.update(btc_id, price).await.unwrap();
@@ -787,7 +790,7 @@ mod tests {
                 } else {
                     panic!("expected price_update")
                 };
-                assert_eq!(price_update.price, Some(100_000_00000000i64));
+                assert_eq!(price_update.price, Some(10_000_000_000_000i64));
             }
             _ => panic!("channel should have a transaction waiting"),
         }