Skip to content

clean up mkdtemp usage #8419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2021
Merged

clean up mkdtemp usage #8419

merged 1 commit into from
Mar 9, 2021

Conversation

asottile
Copy link
Member

@asottile asottile commented Mar 9, 2021 •
edited
Loading

Committed via https://github.com/asottile/all-repos

(I felt that these were slightly better than the previous code, if not -- feel free to close 😄)

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better than before, maybe tmpdir could /should be used and monkeypatch for the cwd

@asottile asottile merged commit 38d8deb into master Mar 9, 2021
@asottile asottile deleted the all-repos_autofix_all-repos-manual branch March 9, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asottile @RonnyPfannschmidt @nicoddemus