Skip to content

Remove report_log in favor of pytest-reportlog #6192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2019
Merged

Remove report_log in favor of pytest-reportlog #6192

merged 1 commit into from
Nov 18, 2019

Conversation

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 14, 2019

Fix #6180

@nicoddemus
Copy link
Member Author

nicoddemus commented Nov 14, 2019

I plan to make the first release of https://github.com/pytest-dev/pytest-reportlog once this gets merged. 👍

@nicoddemus nicoddemus force-pushed the remove-reportlog-6180 branch from 15ad845 to d2ea9e2 Compare November 14, 2019 22:47
Zac-HD
Zac-HD approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@blueyed blueyed mentioned this pull request Nov 15, 2019
Merged
@blueyed
Copy link
Contributor

blueyed commented Nov 15, 2019 •
edited
Loading

@nicoddemus
Cannot really tell currently, but FYI: #6193 (in the new plugin then I guess/assume)
Here: https://github.com/pytest-dev/pytest-reportlog/blob/master/src/pytest_reportlog/plugin.py#L2

Might not be a problem when only used internally, but Path(already_other_Path) would fail then.

@nicoddemus nicoddemus mentioned this pull request Nov 15, 2019
Merged
@nicoddemus
Copy link
Member Author

nicoddemus commented Nov 15, 2019

Thanks @blueyed: pytest-dev/pytest-reportlog#3

nicoddemus added a commit to pytest-dev/pytest-reportlog that referenced this pull request Nov 15, 2019
@nicoddemus
Import Path from _pytest.pathlib
4df7083 
From: pytest-dev/pytest#6192 (comment)
@nicoddemus nicoddemus merged commit 89eeefb into pytest-dev:features Nov 18, 2019
@nicoddemus nicoddemus deleted the remove-reportlog-6180 branch November 18, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zac-HD Zac-HD Zac-HD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicoddemus @blueyed @Zac-HD