Use unicode/bytes literals instead of calls #4309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
oh this is a superset of #4305 |
Member
Author
|
@RonnyPfannschmidt more a continuation -- I was inspired by your change to try and fix more of it :) |
| for i in range(min(len(left), len(right))): | ||
| if left[i] != right[i]: | ||
| explanation += [u("At index %s diff: %r != %r") % (i, left[i], right[i])] | ||
| explanation += [u"At index %s diff: %r != %r" % (i, left[i], right[i])] |
Member
There was a problem hiding this comment.
at the diff i noted that we should use saferepr here, perhaps a nice followup
RonnyPfannschmidt
approved these changes
Nov 5, 2018
Member
|
great job at pulling in the rest 👍 |
Codecov Report
@@ Coverage Diff @@
## master #4309 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 111 111
Lines 24871 24866 -5
Branches 2424 2424
==========================================
- Hits 23837 23832 -5
Misses 737 737
Partials 297 297
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.