Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 13, 2018

help quit in pdb says:

Quit from the debugger. The program being executed is aborted.

But pytest would continue with the next tests, often making it necessary
to kill the pytest process when using --pdb and trying to cancel the
tests using KeyboardInterrupt / Ctrl-C.

TODO:

  • changelog
  • test?

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We also need a test and a CHANGELOG entry. 👍

@blueyed
Copy link
Contributor Author

blueyed commented Oct 13, 2018

py3 displays it as "_pytest.outcomes.Exit: Quitting debugger", while py2 uses Exit: Quitting debugger.
Is this OK?

@nicoddemus
Copy link
Member

I think so, we can improve this later if need be

@blueyed
Copy link
Contributor Author

blueyed commented Oct 13, 2018

I need to touch it anyway again, so might as well add a __repr__ or somethng for Exit.

That's likely not it though, so will just adjust/losen the test in this regard.

@nicoddemus
Copy link
Member

Sounds good, thanks!

`help quit` in pdb says:

> Quit from the debugger. The program being executed is aborted.

But pytest would continue with the next tests, often making it necessary
to kill the pytest process when using `--pdb` and trying to cancel the
tests using `KeyboardInterrupt` / `Ctrl-C`.
@coveralls
Copy link

coveralls commented Oct 13, 2018

Coverage Status

Coverage increased (+0.01%) to 93.791% when pulling 86c7dcf on blueyed:pdb-quit into 27d2683 on pytest-dev:master.

@blueyed blueyed merged commit d6832a8 into pytest-dev:master Oct 14, 2018
@blueyed blueyed deleted the pdb-quit branch October 14, 2018 09:29
@pytest-dev pytest-dev deleted a comment from codecov bot Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants