Skip to content

Conversation

@RonnyPfannschmidt
Copy link
Member

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS, in alphabetical order;

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 92.252% when pulling 76f3be4 on RonnyPfannschmidt:remove-nodeinfo into b2b1eb2 on pytest-dev:master.

@nicoddemus
Copy link
Member

Thanks!

@nicoddemus nicoddemus merged commit 742f9cb into pytest-dev:master Nov 10, 2017
@RonnyPfannschmidt RonnyPfannschmidt deleted the remove-nodeinfo branch November 13, 2017 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants