Skip to content

Conversation

@pradyunsg
Copy link
Contributor

Closes #12573

@webknjaz webknjaz added backport 8.2.x skip news used on prs to opt out of the changelog requirement labels Jul 5, 2024
@nicoddemus
Copy link
Member

Thanks @pradyunsg!

Any reason why this still a Draft?

@ferdnyc
Copy link

ferdnyc commented Jul 6, 2024

If I'm understanding @pradyunsg correctly (see also #12576), the style.html file shouldn't be there at all, and its entire contents should be moved to a .css file that's referenced in html_css_files in the conf.py configuration. (That's what the Sphinx docs say, anyway, and Furo's documentation defers to them on this point.)

I'll put together a PR with that change, including the list-styling fixes here.

@pradyunsg
Copy link
Contributor Author

Since #12581 was filed, I'll go ahead and close this out.

Any reason why this still a Draft?

Because I only did this on the browser and didn't test this out locally/online. Sorry about the lack of context being shared around that. 😅

@pradyunsg pradyunsg closed this Jul 7, 2024
@pradyunsg pradyunsg deleted the patch-1 branch July 7, 2024 10:58
@nicoddemus
Copy link
Member

Because I only did this on the browser and didn't test this out locally/online. Sorry about the lack of context being shared around that. 😅

No worries, thanks for the PR and all the other work you have been putting here, we greatly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news used on prs to opt out of the changelog requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR #12326 made the bullet lists in the change log invisible

4 participants