Skip to content

Commit de42d42

Browse files
committed
Improve code formatting
1 parent 7411e93 commit de42d42

File tree

1 file changed

+11
-24
lines changed

1 file changed

+11
-24
lines changed

_pytest/logging.py

Lines changed: 11 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -272,26 +272,19 @@ def __init__(self, config):
272272
config.option.verbose = 1
273273

274274
self.print_logs = get_option_ini(config, 'log_print')
275-
self.formatter = logging.Formatter(
276-
get_option_ini(config, 'log_format'),
277-
get_option_ini(config, 'log_date_format'))
275+
self.formatter = logging.Formatter(get_option_ini(config, 'log_format'),
276+
get_option_ini(config, 'log_date_format'))
278277
self.log_level = get_actual_log_level(config, 'log_level')
279278

280279
log_file = get_option_ini(config, 'log_file')
281280
if log_file:
282281
self.log_file_level = get_actual_log_level(config, 'log_file_level')
283282

284-
log_file_format = get_option_ini(
285-
config, 'log_file_format', 'log_format')
286-
log_file_date_format = get_option_ini(
287-
config, 'log_file_date_format', 'log_date_format')
288-
self.log_file_handler = logging.FileHandler(
289-
log_file,
290-
# Each pytest runtests session will write to a clean logfile
291-
mode='w')
292-
log_file_formatter = logging.Formatter(
293-
log_file_format,
294-
datefmt=log_file_date_format)
283+
log_file_format = get_option_ini(config, 'log_file_format', 'log_format')
284+
log_file_date_format = get_option_ini(config, 'log_file_date_format', 'log_date_format')
285+
# Each pytest runtests session will write to a clean logfile
286+
self.log_file_handler = logging.FileHandler(log_file, mode='w')
287+
log_file_formatter = logging.Formatter(log_file_format, datefmt=log_file_date_format)
295288
self.log_file_handler.setFormatter(log_file_formatter)
296289
else:
297290
self.log_file_handler = None
@@ -348,18 +341,12 @@ def _setup_cli_logging(self):
348341
terminal_reporter = self._config.pluginmanager.get_plugin('terminalreporter')
349342
if self._config.getini('log_cli') and terminal_reporter is not None:
350343
log_cli_handler = _LiveLoggingStreamHandler(terminal_reporter._tw)
351-
log_cli_format = get_option_ini(
352-
self._config, 'log_cli_format', 'log_format')
353-
log_cli_date_format = get_option_ini(
354-
self._config, 'log_cli_date_format', 'log_date_format')
355-
log_cli_formatter = logging.Formatter(
356-
log_cli_format,
357-
datefmt=log_cli_date_format)
344+
log_cli_format = get_option_ini(self._config, 'log_cli_format', 'log_format')
345+
log_cli_date_format = get_option_ini(self._config, 'log_cli_date_format', 'log_date_format')
346+
log_cli_formatter = logging.Formatter(log_cli_format, datefmt=log_cli_date_format)
358347
log_cli_level = get_actual_log_level(self._config, 'log_cli_level', 'log_level')
359348
self.log_cli_handler = log_cli_handler # needed for a single unittest
360-
self.live_logs_context = catching_logs(log_cli_handler,
361-
formatter=log_cli_formatter,
362-
level=log_cli_level)
349+
self.live_logs_context = catching_logs(log_cli_handler, formatter=log_cli_formatter, level=log_cli_level)
363350
else:
364351
self.log_cli_handler = None
365352
self.live_logs_context = _dummy_context_manager()

0 commit comments

Comments
 (0)