fixtures: change _getautousenames to an iterator

This reads better.

Author: bluetech

src/_pytest/fixtures.py

@@ -1476,14 +1476,12 @@ def pytest_plugin_registered(self, plugin: _PluggyPlugin) -> None:
 
         self.parsefactories(plugin, nodeid)
 
-    def _getautousenames(self, nodeid: str) -> List[str]:
-        """Return a list of fixture names to be used."""
+    def _getautousenames(self, nodeid: str) -> Iterator[str]:
+        """Return the names of autouse fixtures applicable to nodeid."""
         parentnodeids = set(nodes.iterparentnodeids(nodeid))
-        autousenames: List[str] = []
         for baseid, basenames in self._nodeid_and_autousenames:
             if baseid in parentnodeids:
-                autousenames.extend(basenames)
-        return autousenames
+                yield from basenames
 
     def getfixtureclosure(
         self,
@@ -1499,7 +1497,7 @@ def getfixtureclosure(
         # (discovering matching fixtures for a given name/node is expensive).
 
         parentid = parentnode.nodeid
-        fixturenames_closure = self._getautousenames(parentid)
+        fixturenames_closure = list(self._getautousenames(parentid))
 
         def merge(otherlist: Iterable[str]) -> None:
             for arg in otherlist:

testing/python/fixtures.py

@@ -1710,7 +1710,7 @@ def test_parsefactories_conftest(self, testdir):
             """
             from _pytest.pytester import get_public_names
             def test_check_setup(item, fm):
-                autousenames = fm._getautousenames(item.nodeid)
+                autousenames = list(fm._getautousenames(item.nodeid))
                 assert len(get_public_names(autousenames)) == 2
                 assert "perfunction2" in autousenames
                 assert "perfunction" in autousenames