fixup! pytester: testdir: add makefiles helper

Author: blueyed

src/_pytest/pytester.py

@@ -666,16 +666,15 @@ def maketxtfile(self, *args, **kwargs):
         """Shortcut for .makefile() with a .txt extension."""
         return self._makefile(".txt", args, kwargs)
 
-    def makefiles(self, **kwargs: str) -> Optional[Path]:
+    def makefiles(self, **kwargs: str) -> List[Path]:
         """Create the given set of files."""
-        first_path = None
+        paths = []
         for fname, content in kwargs.items():
             path = Path(self.tmpdir).joinpath(Path(fname))
             with open(path, "w") as fp:
                 fp.write(textwrap.dedent(content))
-            if not first_path:
-                first_path = path
-        return first_path
+            paths.append(path)
+        return paths
 
     def syspathinsert(self, path=None):
         """Prepend a directory to sys.path, defaults to :py:attr:`tmpdir`.

testing/test_pytester.py

@@ -715,12 +715,15 @@ def test_error2(bad_fixture):
 
 def test_testdir_makefiles(testdir: Testdir) -> None:
     abspath = str(testdir.tmpdir / "bar")
-    p1 = testdir.makefiles(**{"foo": "", abspath: ""})
+    created_paths = testdir.makefiles(**{"foo": "", abspath: ""})
+    p1 = created_paths[0]
+    assert isinstance(p1, Path)
     relpath = testdir.tmpdir / "foo"
     assert p1 == relpath
 
+    assert str(created_paths[1]) == abspath
     abspath_path = Path(abspath)
     assert abspath_path.exists()
     assert str(abspath_path) == abspath
 
-    assert testdir.makefiles() is None
+    assert testdir.makefiles() == []