Change tests

Author: aklajnert

testing/test_collection.py

@@ -240,49 +240,24 @@ def test_testpaths_ini(self, testdir, monkeypatch):
             items, reprec = testdir.inline_genitems()
             assert [x.name for x in items] == ["test_%s" % dirname]
 
-    @pytest.mark.skipif(sys.platform == "win32", reason="no symlinks on Windows")
-    def test_recursive_absolute_symlinks(self, testdir):
-        """
-        dir
-        ├── link -> /absolute/path/to/dir
-        └── test_recursive.py
-        """
+    @pytest.mark.parametrize("absolute", [True, False])
+    def test_recursive_symlinks(self, testdir, absolute):
+        """Make sure recursive symlinks won't cause multiple collection of the same file."""
         tmpdir = testdir.tmpdir
         directory = tmpdir.mkdir("dir")
         directory.ensure("test_recursive.py").write("def test_recursive(): pass")
-        os.symlink(str(directory), "dir/link")
+        symlink_or_skip(str(directory) if absolute else ".", "dir/link")
 
         items, _ = testdir.inline_genitems()
         assert len(items) == 1
 
-    @pytest.mark.skipif(sys.platform == "win32", reason="no symlinks on Windows")
-    def test_recursive_relative_symlinks(self, testdir):
-        """
-        dir
-        ├── link -> .
-        └── test_recursive.py
-        """
-        tmpdir = testdir.tmpdir
-        directory = tmpdir.mkdir("dir")
-        directory.ensure("test_recursive.py").write("def test_recursive(): pass")
-        os.symlink(".", "dir/link")
-
-        items, _ = testdir.inline_genitems()
-        assert len(items) == 1
-
-    @pytest.mark.skipif(sys.platform == "win32", reason="no symlinks on Windows")
     def test_multiple_recursive_symlinks(self, testdir):
-        """
-        dir
-        ├── link -> .
-        ├── link2 -> link
-        └── test_recursive.py
-        """
+        """Symlink points to recursive symlink. Should be resolved to the very end."""
         tmpdir = testdir.tmpdir
         directory = tmpdir.mkdir("dir")
         directory.ensure("test_recursive.py").write("def test_recursive(): pass")
-        os.symlink(".", "dir/link")
-        os.symlink("link", "dir/link2")
+        symlink_or_skip(".", "dir/link")
+        symlink_or_skip("link", "dir/link2")
 
         items, _ = testdir.inline_genitems()
         assert len(items) == 1