Merge remote-tracking branch 'origin/master' into lru

Author: blueyed

changelog/4181.bugfix.rst

@@ -0,0 +1 @@
+Handle race condition between creation and deletion of temporary folders.

changelog/4243.bugfix.rst

@@ -0,0 +1 @@
+Fix regression when ``stacklevel`` for warnings was passed as positional argument on python2.

changelog/4248.trivial.rst

@@ -0,0 +1 @@
+Remove use of unnecessary compat shim, six.binary_type

src/_pytest/config/__init__.py

@@ -389,13 +389,13 @@ def _getconftestmodules(self, path):
         if self._noconftest:
             return []
 
-        if path.isfile():
-            directory = path.dirpath()
-        else:
-            directory = path
         try:
-            return self._path2confmods[directory]
+            return self._path2confmods[path]
         except KeyError:
+            if path.isfile():
+                directory = path.dirpath()
+            else:
+                directory = path
             # XXX these days we may rather want to use config.rootdir
             # and allow users to opt into looking into the rootdir parent
             # directories instead of requiring to specify confcutdir
@@ -408,7 +408,7 @@ def _getconftestmodules(self, path):
                     mod = self._importconftest(conftestpath)
                     clist.append(mod)
 
-            self._path2confmods[directory] = clist
+            self._path2confmods[path] = clist
             return clist
 
     def _rget_with_confmod(self, name, path):

src/_pytest/pathlib.py

@@ -151,7 +151,7 @@ def create_cleanup_lock(p):
     else:
         pid = os.getpid()
         spid = str(pid)
-        if not isinstance(spid, six.binary_type):
+        if not isinstance(spid, bytes):
             spid = spid.encode("ascii")
         os.write(fd, spid)
         os.close(fd)
@@ -177,9 +177,15 @@ def cleanup_on_exit(lock_path=lock_path, original_pid=pid):
     return register(cleanup_on_exit)
 
 
-def delete_a_numbered_dir(path):
-    """removes a numbered directory"""
-    create_cleanup_lock(path)
+def maybe_delete_a_numbered_dir(path):
+    """removes a numbered directory if its lock can be obtained"""
+    try:
+        create_cleanup_lock(path)
+    except (OSError, EnvironmentError):
+        #  known races:
+        #  * other process did a cleanup at the same time
+        #  * deletable folder was found
+        return
     parent = path.parent
 
     garbage = parent.joinpath("garbage-{}".format(uuid.uuid4()))
@@ -209,7 +215,7 @@ def ensure_deletable(path, consider_lock_dead_if_created_before):
 def try_cleanup(path, consider_lock_dead_if_created_before):
     """tries to cleanup a folder if we can ensure its deletable"""
     if ensure_deletable(path, consider_lock_dead_if_created_before):
-        delete_a_numbered_dir(path)
+        maybe_delete_a_numbered_dir(path)
 
 
 def cleanup_candidates(root, prefix, keep):

src/_pytest/recwarn.py

@@ -156,21 +156,27 @@ def __enter__(self):
         # trivial patching of `warnings.warn` seems to be enough somehow?
         if six.PY2:
 
-            def warn(*args, **kwargs):
-                kwargs.setdefault("stacklevel", 1)
-                kwargs["stacklevel"] += 1
+            def warn(message, category=None, stacklevel=1):
+                # duplicate the stdlib logic due to
+                # bad handing in the c version of warnings
+                if isinstance(message, Warning):
+                    category = message.__class__
+                # Check category argument
+                if category is None:
+                    category = UserWarning
+                assert issubclass(category, Warning)
 
                 # emulate resetting the warn registry
-                f_globals = sys._getframe(kwargs["stacklevel"] - 1).f_globals
+                f_globals = sys._getframe(stacklevel).f_globals
                 if "__warningregistry__" in f_globals:
                     orig = f_globals["__warningregistry__"]
                     f_globals["__warningregistry__"] = None
                     try:
-                        return self._saved_warn(*args, **kwargs)
+                        return self._saved_warn(message, category, stacklevel + 1)
                     finally:
                         f_globals["__warningregistry__"] = orig
                 else:
-                    return self._saved_warn(*args, **kwargs)
+                    return self._saved_warn(message, category, stacklevel + 1)
 
             warnings.warn, self._saved_warn = warn, warnings.warn
         return self

testing/example_scripts/perf_examples/collect_stats/.gitignore

@@ -0,0 +1 @@
+foo_*

testing/example_scripts/perf_examples/collect_stats/generate_folders.py

@@ -0,0 +1,28 @@
+import argparse
+import pathlib
+
+
+HERE = pathlib.Path(__file__).parent
+TEST_CONTENT = (HERE / "template_test.py").read_bytes()
+
+parser = argparse.ArgumentParser()
+parser.add_argument("numbers", nargs="*", type=int)
+
+
+def generate_folders(root, elements, *more_numbers):
+    fill_len = len(str(elements))
+    if more_numbers:
+        for i in range(elements):
+            new_folder = root.joinpath(f"foo_{i:0>{fill_len}}")
+            new_folder.mkdir()
+            new_folder.joinpath("__init__.py").write_bytes(TEST_CONTENT)
+            generate_folders(new_folder, *more_numbers)
+    else:
+        for i in range(elements):
+            new_test = root.joinpath(f"test_{i:0<{fill_len}}.py")
+            new_test.write_bytes(TEST_CONTENT)
+
+
+if __name__ == "__main__":
+    args = parser.parse_args()
+    generate_folders(HERE, *(args.numbers or (10, 100)))

testing/example_scripts/perf_examples/collect_stats/template_test.py

@@ -0,0 +1,2 @@
+def test_x():
+    pass

testing/test_recwarn.py

@@ -46,6 +46,12 @@ def test_recording(self):
             assert values is rec.list
             pytest.raises(AssertionError, "rec.pop()")
 
+    @pytest.mark.issue(4243)
+    def test_warn_stacklevel(self):
+        rec = WarningsRecorder()
+        with rec:
+            warnings.warn("test", DeprecationWarning, 2)
+
     def test_typechecking(self):
         from _pytest.recwarn import WarningsChecker