fix #3605 - unpack markdecorators from parameterization

Author: RonnyPfannschmidt

changelog/3605.bugfix.rst

@@ -0,0 +1 @@
+unpack marks from parameterization to prevent the markdecorator missmatch bug.

src/_pytest/mark/structures.py

@@ -221,9 +221,12 @@ def get_unpacked_marks(obj):
     obtain the unpacked marks that are stored on an object
     """
     mark_list = getattr(obj, "pytestmark", [])
-
     if not isinstance(mark_list, list):
         mark_list = [mark_list]
+    return normalize_mark_list(mark_list)
+
+
+def normalize_mark_list(mark_list):
     return [getattr(mark, "mark", mark) for mark in mark_list]  # unpack MarkDecorator
 
 

src/_pytest/python.py

@@ -39,7 +39,11 @@
     get_default_arg_names,
 )
 from _pytest.outcomes import fail
-from _pytest.mark.structures import transfer_markers, get_unpacked_marks
+from _pytest.mark.structures import (
+    transfer_markers,
+    get_unpacked_marks,
+    normalize_mark_list,
+)
 
 
 # relative paths that we use to filter traceback entries from appearing to the user;
@@ -776,7 +780,7 @@ def setmulti2(self, valtypes, argnames, valset, id, marks, scopenum, param_index
             self.indices[arg] = param_index
             self._arg2scopenum[arg] = scopenum
         self._idlist.append(id)
-        self.marks.extend(marks)
+        self.marks.extend(normalize_mark_list(marks))
 
     def setall(self, funcargs, id, param):
         for x in funcargs:
@@ -1255,7 +1259,7 @@ def __init__(
                 # feel free to cry, this was broken for years before
                 # and keywords cant fix it per design
                 self.keywords[mark.name] = mark
-            self.own_markers.extend(callspec.marks)
+            self.own_markers.extend(normalize_mark_list(callspec.marks))
         if keywords:
             self.keywords.update(keywords)
 

testing/test_mark.py

@@ -1170,4 +1170,4 @@ def test_custom_mark_parametrized(obj_type):
     )
 
     result = testdir.runpytest()
-    result.assert_outcomes(failed=0)
+    result.assert_outcomes(passed=4)