Skip to content

Conversation

@youtux
Copy link
Contributor

@youtux youtux commented Jan 11, 2025

Fix #232

Checklist:

  • To be released only once pytest 8.4 is released and the fix is confirmed to work.

@youtux youtux force-pushed the ab/fix-pytest8.4-compat branch from 85c1776 to 1d468a0 Compare January 11, 2025 23:29
@codecov
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (4bfd25b) to head (25e79e6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pytest_factoryboy/compat.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          14       14           
  Lines         851      852    +1     
  Branches       51       51           
=======================================
+ Hits          832      833    +1     
  Misses          8        8           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@youtux youtux requested a review from Copilot January 11, 2025 23:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@goapunk
Copy link

goapunk commented Jun 27, 2025

@youtux any progress here ? :)

@youtux youtux merged commit 9999a2f into master Jun 27, 2025
19 of 21 checks passed
@youtux youtux deleted the ab/fix-pytest8.4-compat branch June 27, 2025 14:28
seanh added a commit to hypothesis/dependabot-alerts that referenced this pull request Jun 30, 2025
The issue with pytest-factoryboy compatibility is now fixed, see:
pytest-dev/pytest-factoryboy#233
seanh added a commit to hypothesis/dependabot-alerts that referenced this pull request Jun 30, 2025
The issue with pytest-factoryboy compatibility is now fixed, see:
pytest-dev/pytest-factoryboy#233
seanh added a commit to hypothesis/gh-pr-upsert that referenced this pull request Jun 30, 2025
The issue with pytest-factoryboy compatibility is now fixed,
see: pytest-dev/pytest-factoryboy#233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix compatibility with pytest >= 8.4

3 participants