-
Notifications
You must be signed in to change notification settings - Fork 42
Description
Because pytest-factoryboy replaces SubFactory with registered factories, it is possible to inadvertently create circular dependencies, which are not detected by pytest.
In my case, the setup was the following:
UserfactoryCompanyfactory with aContactsubfactory.userfixture overridden in the test file, depending on thecompanyfixturecontactfixture overridden in the same file, depending on thecompanyfixture.
Normally it should be fine because user -> company and contact -> company - there's no cycle. But, because the plugin creates a dependency company -> contact, the graph becomes: user -> company -> contact -> company and there's a cycle. Yet this cycle is a bit magical - I did not ask for company.contact and contact.company to be the same... I want a new, unrelated contact to be created for each company.
Would it be possible to add an option to disable this for those who don't need it? Or only some whitelisted subfactories? In my case, I would like the company.contact factory to be unrelated to the contact factory.