Remove Python 3.8 & Django 5.0 (#1202)

Author: kingbuzzman

.github/workflows/main.yml

@@ -71,6 +71,11 @@ jobs:
           python: '3.13'
           allow_failure: false
 
+        # Explicitly test min pytest.
+        - name: py313-dj52-sqlite-pytestmin-coverage
+          python: '3.13'
+          allow_failure: false
+
         - name: py313-dj52-postgres-xdist-coverage
           python: '3.13'
           allow_failure: false
@@ -131,15 +136,6 @@ jobs:
           python: '3.11'
           allow_failure: false
 
-        - name: py38-dj42-sqlite-xdist-coverage
-          python: '3.8'
-          allow_failure: false
-
-        # Explicitly test min pytest.
-        - name: py38-dj42-sqlite-pytestmin-coverage
-          python: '3.8'
-          allow_failure: false
-
         # pypy3: not included with coverage reports (much slower then).
         - name: pypy3-dj42-postgres
           python: 'pypy3.9'

README.rst

@@ -32,9 +32,9 @@ pytest-django allows you to test your Django project/applications with the
   <https://pytest-django.readthedocs.io/en/latest/contributing.html>`_
 * Version compatibility:
 
-  * Django: 4.2, 5.0, 5.1, 5.2 and latest main branch (compatible at the time
+  * Django: 4.2, 5.1, 5.2 and latest main branch (compatible at the time
     of each release)
-  * Python: CPython>=3.8 or PyPy 3
+  * Python: CPython>=3.9 or PyPy 3
   * pytest: >=7.0
 
   For compatibility with older versions, use previous pytest-django releases.

docs/contributing.rst

@@ -140,10 +140,10 @@ writing), running them all will take a long time. All valid configurations can
 be found in `tox.ini`. To test against a few of them, invoke tox with the `-e`
 flag::
 
-    $ tox -e py38-dj32-postgres,py310-dj41-mysql
+    $ tox -e py39-dj42-postgres,py310-dj52-mysql
 
-This will run the tests on Python 3.8/Django 3.2/PostgeSQL and Python
-3.10/Django 4.1/MySQL.
+This will run the tests on Python 3.9/Django 4.2/PostgeSQL and Python
+3.10/Django 5.2/MySQL.
 
 
 Measuring test coverage

pyproject.toml

@@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta"
 name = "pytest-django"
 description = "A Django plugin for pytest."
 readme = "README.rst"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 dynamic = ["version"]
 authors = [
     { name = "Andreas Pelme", email = "[email protected]" },
@@ -22,14 +22,12 @@ classifiers = [
     "Development Status :: 5 - Production/Stable",
     "Framework :: Django",
     "Framework :: Django :: 4.2",
-    "Framework :: Django :: 5.0",
     "Framework :: Django :: 5.1",
     "Framework :: Django :: 5.2",
     "Intended Audience :: Developers",
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

pytest_django/asserts.py

@@ -4,8 +4,9 @@
 
 from __future__ import annotations
 
+from collections.abc import Sequence
 from functools import wraps
-from typing import TYPE_CHECKING, Any, Callable, Sequence
+from typing import TYPE_CHECKING, Any, Callable
 
 from django import VERSION
 from django.test import LiveServerTestCase, SimpleTestCase, TestCase, TransactionTestCase

pytest_django/fixtures.py

@@ -3,24 +3,10 @@
 from __future__ import annotations
 
 import os
-from contextlib import contextmanager
+from collections.abc import Generator, Iterable, Sequence
+from contextlib import AbstractContextManager, contextmanager
 from functools import partial
-from typing import (
-    TYPE_CHECKING,
-    AbstractSet,
-    Any,
-    Callable,
-    ContextManager,
-    Generator,
-    Iterable,
-    List,
-    Literal,
-    Optional,
-    Protocol,
-    Sequence,
-    Tuple,
-    Union,
-)
+from typing import TYPE_CHECKING, Any, Callable, Literal, Optional, Protocol, Union
 
 import pytest
 
@@ -37,9 +23,9 @@
 
 
 _DjangoDbDatabases = Optional[Union[Literal["__all__"], Iterable[str]]]
-_DjangoDbAvailableApps = Optional[List[str]]
+_DjangoDbAvailableApps = Optional[list[str]]
 # transaction, reset_sequences, databases, serialized_rollback, available_apps
-_DjangoDb = Tuple[bool, bool, _DjangoDbDatabases, bool, _DjangoDbAvailableApps]
+_DjangoDb = tuple[bool, bool, _DjangoDbDatabases, bool, _DjangoDbAvailableApps]
 
 
 __all__ = [
@@ -157,7 +143,7 @@ def _get_databases_for_test(test: pytest.Item) -> tuple[Iterable[str], bool]:
 
 def _get_databases_for_setup(
     items: Sequence[pytest.Item],
-) -> tuple[AbstractSet[str], AbstractSet[str]]:
+) -> tuple[set[str], set[str]]:
     """Get the database aliases that need to be setup, and the subset that needs
     to be serialized."""
     # Code derived from django.test.utils.DiscoverRunner.get_databases().
@@ -736,7 +722,7 @@ def __call__(
         *,
         using: str = ...,
         execute: bool = ...,
-    ) -> ContextManager[list[Callable[[], Any]]]:
+    ) -> AbstractContextManager[list[Callable[[], Any]]]:
         pass  # pragma: no cover
 
 

pytest_django/plugin.py

@@ -12,8 +12,10 @@
 import pathlib
 import sys
 import types
+from collections.abc import Generator
+from contextlib import AbstractContextManager
 from functools import reduce
-from typing import TYPE_CHECKING, ContextManager, Generator, List, NoReturn
+from typing import TYPE_CHECKING, NoReturn
 
 import pytest
 
@@ -259,7 +261,7 @@ def _get_boolean_value(
         ) from None
 
 
-report_header_key = pytest.StashKey[List[str]]()
+report_header_key = pytest.StashKey[list[str]]()
 
 
 @pytest.hookimpl()
@@ -837,13 +839,13 @@ def _blocking_wrapper(*args, **kwargs) -> NoReturn:
             '"db" or "transactional_db" fixtures to enable it.'
         )
 
-    def unblock(self) -> ContextManager[None]:
+    def unblock(self) -> AbstractContextManager[None]:
         """Enable access to the Django database."""
         self._save_active_wrapper()
         self._dj_db_wrapper.ensure_connection = self._real_ensure_connection
         return _DatabaseBlockerContextManager(self)
 
-    def block(self) -> ContextManager[None]:
+    def block(self) -> AbstractContextManager[None]:
         """Disable access to the Django database."""
         self._save_active_wrapper()
         self._dj_db_wrapper.ensure_connection = self._blocking_wrapper

pytest_django/runner.py

@@ -1,5 +1,6 @@
 from argparse import ArgumentParser
-from typing import Any, Iterable
+from collections.abc import Iterable
+from typing import Any
 
 
 class TestRunner:

pytest_django_test/db_helpers.py

@@ -3,7 +3,7 @@
 import os
 import sqlite3
 import subprocess
-from typing import Mapping
+from collections.abc import Mapping
 
 import pytest
 from django.conf import settings

tests/test_database.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import Generator
+from collections.abc import Generator
 
 import pytest
 from django.db import connection, transaction