make it raise PytestDeprecationWarning instead

Author: jakkdl

pytest_asyncio/plugin.py

@@ -881,7 +881,7 @@ def pytest_pyfunc_call(pyfuncitem: Function) -> object | None:
     if pyfuncitem.get_closest_marker("asyncio") is not None:
         if isinstance(pyfuncitem, PytestAsyncioFunction):
             asyncio_mode = _get_asyncio_mode(pyfuncitem.config)
-            for fixtures in pyfuncitem._fixtureinfo.name2fixturedefs.values():
+            for fixname, fixtures in pyfuncitem._fixtureinfo.name2fixturedefs.items():
                 # name2fixturedefs is a dict between fixture name and a list of matching
                 # fixturedefs. The last entry in the list is closest and the one used.
                 func = fixtures[-1].func
@@ -890,10 +890,22 @@ def pytest_pyfunc_call(pyfuncitem: Function) -> object | None:
                     and not _is_asyncio_fixture_function(func)
                     and asyncio_mode == Mode.STRICT
                 ):
-                    pytest.fail(
-                        "asyncio test requested async fixture not marked asyncio, "
-                        "in strict mode. You might want to use @pytest_asyncio.fixture"
+                    warnings.warn(
+                        PytestDeprecationWarning(
+                            f"asyncio test {pyfuncitem.name!r} requested async "
+                            "@pytest.fixture "
+                            f"{fixname!r} in strict mode. "
+                            "You might want to use @pytest_asyncio.fixture or switch "
+                            "to auto mode. "
+                            "This will become an error in future versions of "
+                            "flake8-asyncio."
+                        ),
+                        stacklevel=1,
                     )
+                    # no stacklevel points at the users code, so we set stacklevel=1
+                    # so it at least indicates that it's the plugin complaining.
+                    # Pytest gives the test file & name in the warnings summary at least
+
         else:
             pyfuncitem.warn(
                 pytest.PytestWarning(

tests/modes/test_strict_mode.py

@@ -126,7 +126,7 @@ async def test_anything(any_fixture):
     )
 
 
-def test_strict_mode_marked_test_errors_unmarked_fixture(pytester: Pytester):
+def test_strict_mode_marked_test_unmarked_fixture_warning(pytester: Pytester):
     pytester.makeini("[pytest]\nasyncio_default_fixture_loop_scope = function")
     pytester.makepyfile(
         dedent(
@@ -136,19 +136,78 @@ def test_strict_mode_marked_test_errors_unmarked_fixture(pytester: Pytester):
         # Not using pytest_asyncio.fixture
         @pytest.fixture()
         async def any_fixture():
-            raise RuntimeError()
+            pass
 
         @pytest.mark.asyncio
         async def test_anything(any_fixture):
+            # suppress unawaited coroutine warning
+            try:
+                any_fixture.send(None)
+            except StopIteration:
+                pass
+        """
+        )
+    )
+    result = pytester.runpytest_subprocess("--asyncio-mode=strict", "-W default")
+    result.assert_outcomes(passed=1, failed=0, skipped=0, warnings=1)
+    result.stdout.fnmatch_lines(
+        [
+            "*warnings summary*",
+            (
+                "test_strict_mode_marked_test_unmarked_fixture_warning.py::"
+                "test_anything"
+            ),
+            (
+                "*/pytest_asyncio/plugin.py:*: PytestDeprecationWarning: "
+                "asyncio test 'test_anything' requested async "
+                "@pytest.fixture 'any_fixture' in strict mode. "
+                "You might want to use @pytest_asyncio.fixture or switch to "
+                "auto mode. "
+                "This will become an error in future versions of flake8-asyncio."
+            ),
+        ],
+    )
+
+
+# autouse is not handled in any special way currently
+def test_strict_mode_marked_test_unmarked_autouse_fixture_warning(pytester: Pytester):
+    pytester.makeini("[pytest]\nasyncio_default_fixture_loop_scope = function")
+    pytester.makepyfile(
+        dedent(
+            """\
+        import pytest
+
+        # Not using pytest_asyncio.fixture
+        @pytest.fixture(autouse=True)
+        async def any_fixture():
             pass
+
+        @pytest.mark.asyncio
+        async def test_anything(any_fixture):
+            # suppress unawaited coroutine warning
+            try:
+                any_fixture.send(None)
+            except StopIteration:
+                pass
         """
         )
     )
     result = pytester.runpytest_subprocess("--asyncio-mode=strict", "-W default")
-    result.assert_outcomes(failed=1, skipped=0, warnings=1)
+    result.assert_outcomes(passed=1, warnings=1)
     result.stdout.fnmatch_lines(
         [
-            "*asyncio test requested async fixture not marked asyncio, in strict mode*",
-            "*coroutine 'any_fixture' was never awaited*",
+            "*warnings summary*",
+            (
+                "test_strict_mode_marked_test_unmarked_autouse_fixture_warning.py::"
+                "test_anything"
+            ),
+            (
+                "*/pytest_asyncio/plugin.py:*: PytestDeprecationWarning: "
+                "*asyncio test 'test_anything' requested async "
+                "@pytest.fixture 'any_fixture' in strict mode. "
+                "You might want to use @pytest_asyncio.fixture or switch to "
+                "auto mode. "
+                "This will become an error in future versions of flake8-asyncio."
+            ),
         ],
     )