Remove get_summaries().

Author: cjerdonek

src/pip/_internal/cli/autocompletion.py

@@ -6,7 +6,7 @@
 import sys
 
 from pip._internal.cli.main_parser import create_main_parser
-from pip._internal.commands import create_command, get_summaries
+from pip._internal.commands import commands_dict, create_command
 from pip._internal.utils.misc import get_installed_distributions
 
 
@@ -23,7 +23,7 @@ def autocomplete():
     except IndexError:
         current = ''
 
-    subcommands = [cmd for cmd, summary in get_summaries()]
+    subcommands = list(commands_dict)
     options = []
     # subcommand
     try:

src/pip/_internal/cli/main_parser.py

@@ -9,11 +9,7 @@
     ConfigOptionParser,
     UpdatingDefaultsHelpFormatter,
 )
-from pip._internal.commands import (
-    commands_dict,
-    get_similar_commands,
-    get_summaries,
-)
+from pip._internal.commands import commands_dict, get_similar_commands
 from pip._internal.exceptions import CommandError
 from pip._internal.utils.misc import get_pip_version, get_prog
 from pip._internal.utils.typing import MYPY_CHECK_RUNNING
@@ -51,8 +47,10 @@ def create_main_parser():
     parser.main = True  # type: ignore
 
     # create command listing for description
-    command_summaries = get_summaries()
-    description = [''] + ['%-27s %s' % (i, j) for i, j in command_summaries]
+    description = [''] + [
+        '%-27s %s' % (name, command_info.summary)
+        for name, command_info in commands_dict.items()
+    ]
     parser.description = '\n'.join(description)
 
     return parser

src/pip/_internal/commands/__init__.py

@@ -9,7 +9,7 @@
 from pip._internal.utils.typing import MYPY_CHECK_RUNNING
 
 if MYPY_CHECK_RUNNING:
-    from typing import Any, Iterable, Tuple
+    from typing import Any
     from pip._internal.cli.base_command import Command
 
 
@@ -96,13 +96,6 @@ def create_command(name, **kwargs):
     return command
 
 
-def get_summaries():
-    # type: () -> Iterable[Tuple[str, str]]
-    """Yield command (name, summary) tuples in display order."""
-    for name, command_info in commands_dict.items():
-        yield (name, command_info.summary)
-
-
 def get_similar_commands(name):
     """Command name auto-correct."""
     from difflib import get_close_matches

tests/unit/test_commands.py

@@ -1,6 +1,6 @@
 import pytest
 
-from pip._internal.commands import commands_dict, create_command, get_summaries
+from pip._internal.commands import commands_dict, create_command
 
 
 def test_commands_dict__order():
@@ -20,12 +20,3 @@ def test_create_command(name):
     command = create_command(name)
     assert command.name == name
     assert command.summary == commands_dict[name].summary
-
-
-def test_get_summaries():
-    actual = list(get_summaries())
-    for name, summary in actual:
-        assert summary == commands_dict[name].summary
-
-    # Also check that the result is ordered correctly.
-    assert [item[0] for item in actual] == list(commands_dict)