fixup! Refactor the logic in self_outdated_check

Author: pradyunsg

tests/unit/test_self_check_outdated.py

@@ -131,8 +131,8 @@ def test_pip_self_version_check(
     monkeypatch.setattr(logger, "debug", mock.Mock())
 
     fake_state = mock.Mock(
-        state={"last_check": stored_time, "pypi_version": installed_ver},
-        save=mock.Mock(),
+        get=mock.Mock(return_value=None),
+        set=mock.Mock(),
     )
     monkeypatch.setattr(self_outdated_check, "SelfCheckState", lambda **kw: fake_state)
 
@@ -146,16 +146,16 @@ def test_pip_self_version_check(
     ):
         pip_self_version_check(PipSession(), _options())
 
-    # See that we saved the correct version
+    # See that we set the correct version
     if check_if_upgrade_required:
-        assert fake_state.save.call_args_list == [
+        assert fake_state.set.call_args_list == [
             mock.call(new_ver, datetime.datetime(1970, 1, 9, 10, 00, 00)),
         ]
     elif installed_ver:
         # Make sure no Exceptions
         assert not cast(mock.Mock, logger.debug).call_args_list
-        # See that save was not called
-        assert fake_state.save.call_args_list == []
+        # See that set was not called
+        assert fake_state.set.call_args_list == []
 
     # Ensure we warn the user or not
     if check_warn_logs: