Skip to content

Allow for scalar or size 1 mu in MvNormal and MvStudentT #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2022
Merged

Allow for scalar or size 1 mu in MvNormal and MvStudentT #5386

merged 2 commits into from
Jan 27, 2022

Conversation

@ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jan 25, 2022

Just for user friendliness, as this was accepted in V3

@ricardoV94 ricardoV94 requested a review from Sayam753 January 25, 2022 11:01
@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #5386 (d28fff5) into main (eb5177a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5386      +/-   ##
==========================================
- Coverage   80.44%   80.40%   -0.05%     
==========================================
  Files          82       82              
  Lines       14132    14154      +22     
==========================================
+ Hits        11369    11380      +11     
- Misses       2763     2774      +11
Impacted Files Coverage Δ
pymc/distributions/multivariate.py 76.01% <100.00%> (+0.43%) ⬆️
pymc/step_methods/elliptical_slice.py 61.90% <0.00%> (-4.77%) ⬇️
pymc/parallel_sampling.py 86.71% <0.00%> (-1.00%) ⬇️
pymc/sampling.py 85.84% <0.00%> (-0.71%) ⬇️
pymc/__init__.py 100.00% <0.00%> (ø)
pymc/distributions/discrete.py 98.79% <0.00%> (+0.02%) ⬆️

@ricardoV94 ricardoV94 marked this pull request as draft January 25, 2022 13:51
@ricardoV94 ricardoV94 marked this pull request as ready for review January 26, 2022 07:44
Sayam753
Sayam753 reviewed Jan 26, 2022
View reviewed changes
@ricardoV94
Add test name check in BaseTestDistribution
c39999c 
* If custom tests start with `test_` they would have run twice, once called by the `BaseTestDistribution` and once by `pytest`
* For consistency rename `tests_to_run` to `checks_to_run`
* Also fixes TestWald hack which unnecessarily overrode bast class methods
@ricardoV94
Allow for scalar or size 1 mu in MvNormal and MvStudentT
d28fff5
@ricardoV94
Copy link
Member Author

ricardoV94 commented Jan 27, 2022

Failing test is flaky: #5411

Sayam753
Sayam753 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@Sayam753 Sayam753 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

We may need to revisit here after #5383 gets solved, because if cov parameter supports batch dimensions, it may require broadcasting against mu.

@ricardoV94 ricardoV94 merged commit 657eb2a into pymc-devs:main Jan 27, 2022
@ricardoV94
Copy link
Member Author

ricardoV94 commented Jan 27, 2022

Thanks for reviewing @Sayam753

Are you interested in picking some of #5383?

@Sayam753
Copy link
Member

Sayam753 commented Jan 27, 2022

Yeah. Let's do it.

@ricardoV94 ricardoV94 deleted the scalar_mu_mv branch January 31, 2022 09:21
This was referenced Feb 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sayam753 Sayam753 Sayam753 approved these changes

Assignees

No one assigned

Labels

request discussion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ricardoV94 @Sayam753