Remove unused position tags

These should have been provided as keyword arguments, but they don't seem to matter anyway

Author: ricardoV94

pymc/logprob/censoring.py

@@ -110,7 +110,6 @@ def find_measurable_clips(fgraph: FunctionGraph, node: Node) -> Optional[List[Me
 measurable_ir_rewrites_db.register(
     "find_measurable_clips",
     find_measurable_clips,
-    0,
     "basic",
     "censoring",
 )
@@ -220,7 +219,6 @@ def find_measurable_roundings(fgraph: FunctionGraph, node: Node) -> Optional[Lis
 measurable_ir_rewrites_db.register(
     "find_measurable_roundings",
     find_measurable_roundings,
-    0,
     "basic",
     "censoring",
 )

pymc/logprob/cumsum.py

@@ -122,7 +122,6 @@ def find_measurable_cumsums(fgraph, node) -> Optional[List[MeasurableCumsum]]:
 measurable_ir_rewrites_db.register(
     "find_measurable_cumsums",
     find_measurable_cumsums,
-    0,
     "basic",
     "cumsum",
 )

pymc/logprob/mixture.py

@@ -461,7 +461,6 @@ def logprob_MixtureRV(
         [mixture_replace, switch_mixture_replace],
         max_use_ratio=pytensor.config.optdb__max_use_ratio,
     ),
-    0,
     "basic",
     "mixture",
 )

pymc/logprob/rewriting.py

@@ -252,23 +252,23 @@ def incsubtensor_rv_replace(fgraph, node):
 
 logprob_rewrites_db = SequenceDB()
 logprob_rewrites_db.name = "logprob_rewrites_db"
-logprob_rewrites_db.register("pre-canonicalize", optdb.query("+canonicalize"), -10, "basic")
+logprob_rewrites_db.register("pre-canonicalize", optdb.query("+canonicalize"), "basic")
 
 # These rewrites convert un-measurable variables into their measurable forms,
 # but they need to be reapplied, because some of the measurable forms require
 # their inputs to be measurable.
 measurable_ir_rewrites_db = NoCallbackEquilibriumDB()
 measurable_ir_rewrites_db.name = "measurable_ir_rewrites_db"
 
-logprob_rewrites_db.register("measurable_ir_rewrites", measurable_ir_rewrites_db, -10, "basic")
+logprob_rewrites_db.register("measurable_ir_rewrites", measurable_ir_rewrites_db, "basic")
 
 # These rewrites push random/measurable variables "down", making them closer to
 # (or eventually) the graph outputs.  Often this is done by lifting other `Op`s
 # "up" through the random/measurable variables and into their inputs.
-measurable_ir_rewrites_db.register("subtensor_lift", local_subtensor_rv_lift, -5, "basic")
-measurable_ir_rewrites_db.register("incsubtensor_lift", incsubtensor_rv_replace, -5, "basic")
+measurable_ir_rewrites_db.register("subtensor_lift", local_subtensor_rv_lift, "basic")
+measurable_ir_rewrites_db.register("incsubtensor_lift", incsubtensor_rv_replace, "basic")
 
-logprob_rewrites_db.register("post-canonicalize", optdb.query("+canonicalize"), 10, "basic")
+logprob_rewrites_db.register("post-canonicalize", optdb.query("+canonicalize"), "basic")
 
 
 def construct_ir_fgraph(

pymc/logprob/scan.py

@@ -530,19 +530,17 @@ def _get_measurable_outputs_MeasurableScan(op, node):
     # out2in(
     #     add_opts_to_inner_graphs, name="add_opts_to_inner_graphs", ignore_newtrees=True
     # ),
-    -100,
     "basic",
     "scan",
 )
 
 measurable_ir_rewrites_db.register(
     "find_measurable_scans",
     find_measurable_scans,
-    0,
     "basic",
     "scan",
 )
 
 # Add scan canonicalizations that aren't in the canonicalization DB
-logprob_rewrites_db.register("scan_eqopt1", scan_eqopt1, -9, "basic", "scan")
-logprob_rewrites_db.register("scan_eqopt2", scan_eqopt2, -9, "basic", "scan")
+logprob_rewrites_db.register("scan_eqopt1", scan_eqopt1, "basic", "scan")
+logprob_rewrites_db.register("scan_eqopt2", scan_eqopt2, "basic", "scan")

pymc/logprob/tensor.py

@@ -311,24 +311,21 @@ def find_measurable_dimshuffles(fgraph, node) -> Optional[List[MeasurableDimShuf
     return [measurable_dimshuffle]
 
 
-measurable_ir_rewrites_db.register(
-    "dimshuffle_lift", local_dimshuffle_rv_lift, -5, "basic", "tensor"
-)
+measurable_ir_rewrites_db.register("dimshuffle_lift", local_dimshuffle_rv_lift, "basic", "tensor")
 
 
 # We register this later than `dimshuffle_lift` so that it is only applied as a fallback
 measurable_ir_rewrites_db.register(
-    "find_measurable_dimshuffles", find_measurable_dimshuffles, 0, "basic", "tensor"
+    "find_measurable_dimshuffles", find_measurable_dimshuffles, "basic", "tensor"
 )
 
 
-measurable_ir_rewrites_db.register("broadcast_to_lift", naive_bcast_rv_lift, -5, "basic", "tensor")
+measurable_ir_rewrites_db.register("broadcast_to_lift", naive_bcast_rv_lift, "basic", "tensor")
 
 
 measurable_ir_rewrites_db.register(
     "find_measurable_stacks",
     find_measurable_stacks,
-    0,
     "basic",
     "tensor",
 )

pymc/logprob/transforms.py

@@ -373,7 +373,6 @@ def find_measurable_transforms(fgraph: FunctionGraph, node: Node) -> Optional[Li
 measurable_ir_rewrites_db.register(
     "find_measurable_transforms",
     find_measurable_transforms,
-    0,
     "basic",
     "transform",
 )

scripts/run_mypy.py

@@ -47,6 +47,7 @@
 pymc/gp/util.py
 pymc/logprob/__init__.py
 pymc/logprob/abstract.py
+pymc/logprob/cumsum.py
 pymc/math.py
 pymc/ode/__init__.py
 pymc/ode/ode.py